[HWKMETRICS-765] remove DeleteExpiredMetrics job and related code #923
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR does not remove expirationIndex writers from DataAccessImpl.updateMetricExpirationIndex and it's still called from MetricsServiceImpl compression code (this should result in a failure since the table is gone) |
I have also disabled a test in MixedMetricsITest which fails inconsistently.
jsanda
pushed a commit
to jsanda/hawkular-metrics
that referenced
this pull request
Mar 27, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest which fails inconsistently.
jsanda
pushed a commit
that referenced
this pull request
Mar 27, 2018
[HWKMETRICS-765] remove DeleteExpiredMetrics job and related code (#923)
rubenvp8510
pushed a commit
to rubenvp8510/hawkular-metrics
that referenced
this pull request
Apr 10, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest which fails inconsistently.
rubenvp8510
pushed a commit
to rubenvp8510/hawkular-metrics
that referenced
this pull request
Apr 10, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest which fails inconsistently.
rubenvp8510
pushed a commit
to rubenvp8510/hawkular-metrics
that referenced
this pull request
Apr 10, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest which fails inconsistently.
rubenvp8510
pushed a commit
to rubenvp8510/hawkular-metrics
that referenced
this pull request
Apr 10, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest which fails inconsistently.
rubenvp8510
pushed a commit
to rubenvp8510/hawkular-metrics
that referenced
this pull request
Apr 10, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest which fails inconsistently.
rubenvp8510
pushed a commit
to rubenvp8510/hawkular-metrics
that referenced
this pull request
Apr 10, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest and DataAccessItest::testFindAllDataFromBucket which fails inconsistently.
rubenvp8510
pushed a commit
to rubenvp8510/hawkular-metrics
that referenced
this pull request
Apr 10, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest and DataAccessItest::testFindAllDataFromBucket which fails inconsistently.
rubenvp8510
pushed a commit
to rubenvp8510/hawkular-metrics
that referenced
this pull request
Apr 10, 2018
…wkular#923) * [HWKMETRICS-765] remove DeleteExpiredMetrics job and related code * [HWKMETRICS-765] remove more code related to metrics_expiration_idx I have also disabled a test in MixedMetricsITest and DataAccessItest::testFindAllDataFromBucket which fails inconsistently.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.