[HWKMETRICS-787] release/0.30.0 branch #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Optimize Openshift tag queries * [HWKMETRICS-787] clean up pod_id tag query logic and add tests * [HWKMETRICS-787] clean up pod_id query and add some debug logging I removed the reduce operation since it is not needed. This whole optimization is for a particular tag key. There can only be one instance of a tag key per request; hence, the reduce operation is not needed. * [HWKMETRICS-787] disable failing test I spent a few minutes investigating, but I am not going to wast any more time. The delete tenant functionality has never been used, and the REST integration tests are tricky due to using the "virtual clock" which in turn makes these tests brittle. I will open a separate ticket for disabling the delete tenant functionality. We can leave the endpoints intact but return an appropriate status and error message indicating that it is no longer supported.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optimize Openshift tag queries
[HWKMETRICS-787] clean up pod_id tag query logic and add tests
[HWKMETRICS-787] clean up pod_id query and add some debug logging
I removed the reduce operation since it is not needed. This whole
optimization is for a particular tag key. There can only be one instance
of a tag key per request; hence, the reduce operation is not needed.
I spent a few minutes investigating, but I am not going to wast any more
time. The delete tenant functionality has never been used, and the REST
integration tests are tricky due to using the "virtual clock" which in
turn makes these tests brittle.
I will open a separate ticket for disabling the delete tenant
functionality. We can leave the endpoints intact but return an
appropriate status and error message indicating that it is no longer
supported.