Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HAWKULAR-176 Make maven to add git SHA1, branch and build time to #21

Merged
merged 1 commit into from May 13, 2015

Conversation

ppalaga
Copy link
Contributor

@ppalaga ppalaga commented May 11, 2015

manifest.mf

@pilhuhn
Copy link
Member

pilhuhn commented May 11, 2015

@tsegismont I think you reviewed this?

@ppalaga
Copy link
Contributor Author

ppalaga commented May 11, 2015

@pilhuhn , Thomas reviewed, but I need to make sure that the change works well in all projects. I'll merge after that.

@tsegismont
Copy link
Contributor

Yes I did, I'll copy what I said in the ML to Git Hub

2015-05-11 18:32 GMT+02:00 Peter Palaga notifications@github.com:

@pilhuhn https://github.com/pilhuhn , Thomas reviewed, but I need to
make sure that the change works well in all projects. I'll merge after that.


Reply to this email directly or view it on GitHub
#21 (comment)
.

@tsegismont
Copy link
Contributor

I suppose the last part of the PR is not related to the recent Kettle
issues.
To me failing the build if local changes are present sounds like a good
idea. But we must make sure that no plugin generates files outside of
the "target" directory. Until recently the Swagger Maven plugin was
writing doc files to the REST project base directory, for example.

If this is true then the PR looks good to me and it can be merged.

@stefannegrea
Copy link

Is this change going to affect all the artifacts created by individual projects?

@ppalaga
Copy link
Contributor Author

ppalaga commented May 13, 2015

@stefannegrea yes, this change will affect all artifacts (jars, wars and ears) created by individual projects as soon as the given project adopts the next hawkular parent version.

ppalaga added a commit that referenced this pull request May 13, 2015
HAWKULAR-176 Make maven to add git SHA1, branch and build time to
@ppalaga ppalaga merged commit eef6bd9 into hawkular:master May 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants