Skip to content

Commit

Permalink
ChartController refactor.
Browse files Browse the repository at this point in the history
  • Loading branch information
mtho11 committed Feb 11, 2015
1 parent 8c86fee commit 451b994
Showing 1 changed file with 7 additions and 9 deletions.
16 changes: 7 additions & 9 deletions plugins/metrics/plugins/metrics/ts/graphs.ts
Original file line number Diff line number Diff line change
Expand Up @@ -111,9 +111,7 @@ module HawkularMetrics {
$scope.vm.startTimeStamp = timeRange[0];
$scope.vm.endTimeStamp = timeRange[1];
$scope.vm.dateRange = moment(timeRange[0]).from(moment(timeRange[1]));
$scope.vm.refreshHistoricalChartDataForTimestamp(startTimeStamp, endTimeStamp);


$scope.vm.refreshHistoricalChartDataForTimestamp(startTimeStamp.getTime(), endTimeStamp.getTime());
});

}
Expand All @@ -135,7 +133,7 @@ module HawkularMetrics {
toastr.warning('No Data found for id: ' + id);
}

private calculatePreviousTimeRange(startDate:Date, endDate:Date):any {
private static calculatePreviousTimeRange(startDate:Date, endDate:Date):any {
var previousTimeRange:Date[] = [];
var intervalInMillis = endDate.getTime() - startDate.getTime();

Expand All @@ -145,7 +143,7 @@ module HawkularMetrics {
}

showPreviousTimeRange():void {
var previousTimeRange = this.calculatePreviousTimeRange(this.startTimeStamp, this.endTimeStamp);
var previousTimeRange = ChartController.calculatePreviousTimeRange(this.startTimeStamp, this.endTimeStamp);

this.startTimeStamp = previousTimeRange[0];
this.endTimeStamp = previousTimeRange[1];
Expand All @@ -154,7 +152,7 @@ module HawkularMetrics {
}


private calculateNextTimeRange(startDate:Date, endDate:Date):any {
private static calculateNextTimeRange(startDate:Date, endDate:Date):any {
var nextTimeRange = [];
var intervalInMillis = endDate.getTime() - startDate.getTime();

Expand All @@ -165,7 +163,7 @@ module HawkularMetrics {


showNextTimeRange():void {
var nextTimeRange = this.calculateNextTimeRange(this.startTimeStamp, this.endTimeStamp);
var nextTimeRange = ChartController.calculateNextTimeRange(this.startTimeStamp, this.endTimeStamp);

this.startTimeStamp = nextTimeRange[0];
this.endTimeStamp = nextTimeRange[1];
Expand All @@ -175,7 +173,7 @@ module HawkularMetrics {


hasNext():boolean {
var nextTimeRange = this.calculateNextTimeRange(this.startTimeStamp, this.endTimeStamp);
var nextTimeRange = ChartController.calculateNextTimeRange(this.startTimeStamp, this.endTimeStamp);
// unsophisticated test to see if there is a next; without actually querying.

//@fixme: pay the price, do the query!
Expand Down Expand Up @@ -267,7 +265,7 @@ module HawkularMetrics {


overlayPreviousRangeData():void {
var previousTimeRange = this.calculatePreviousTimeRange(this.startTimeStamp, this.endTimeStamp);
var previousTimeRange = ChartController.calculatePreviousTimeRange(this.startTimeStamp, this.endTimeStamp);

if (this.searchId !== '') {
this.metricDataService.getMetricsForTimeRange(this.searchId, previousTimeRange[0], previousTimeRange[1])
Expand Down

0 comments on commit 451b994

Please sign in to comment.