Removing straightforward IDE warns and errs

hawkular · Apr 3, 2015 · 64111ff · 64111ff
1 parent 81432e8
commit 64111ff
Show file tree

Hide file tree

Showing 8 changed files with 11 additions and 11 deletions.
diff --git a/plugins/accounts/plugins/accounts/ts/authInterceptor.ts b/plugins/accounts/plugins/accounts/ts/authInterceptor.ts
@@ -14,6 +14,7 @@
 /// limitations under the License.
 
 /// <reference path="accountsPlugin.ts"/>
+/// <reference path="auth.ts"/>
 /**
  * Attention: this class will probably be replaced by the proper hawt.io Keycloak integration.
  * While it's not done, we are doing the integration by ourselves.

diff --git a/plugins/alerts/plugins/alerts/ts/actions.ts b/plugins/alerts/plugins/alerts/ts/actions.ts
@@ -24,7 +24,7 @@ module HawkularAlerts {
         deleteAction(actionId: string):void;
         closeAlertMsg(index: number):void;
         changePlugin():void;
-    };
+    }
 
     export class ActionsController implements IActionsController {
         public static  $inject = ['$scope', '$window', '$interval', '$log', 'HawkularAlert'];
@@ -152,7 +152,7 @@ module HawkularAlerts {
             this.$scope.msgs.splice(index, 1);
         }
 
-    };
+    }
 
     _module.controller('HawkularAlerts.ActionsController', ActionsController);
 }
diff --git a/plugins/alerts/plugins/alerts/ts/dashboard.ts b/plugins/alerts/plugins/alerts/ts/dashboard.ts
@@ -20,7 +20,7 @@ module HawkularAlerts {
         showRefreshForm(): void;
         hideRefreshForm(): void;
         updateRefresh(): void;
-    };
+    }
 
     export class DashboardController implements IDashboardController {
         public static  $inject = ['$scope', '$interval', '$log', 'HawkularAlert'];
@@ -123,7 +123,7 @@ module HawkularAlerts {
             }
             this.$scope.msgs.push(newAlert);
         }
-    };
+    }
 
     _module.controller('HawkularAlerts.DashboardController', DashboardController);
 

diff --git a/plugins/alerts/plugins/alerts/ts/definitions.ts b/plugins/alerts/plugins/alerts/ts/definitions.ts
@@ -30,7 +30,7 @@ module HawkularAlerts {
         deleteCondition(conditionId: string, description: string):void;
         cancelCondition():void;
         saveDampening():void;
-    };
+    }
 
     export class DefinitionsController implements IDefinitionsController {
         public static  $inject = ['$scope', '$window', '$log', 'HawkularAlert'];
@@ -371,7 +371,7 @@ module HawkularAlerts {
             this.$scope.statusCondition = {status: ''};
         }
 
-    };
+    }
 
     _module.controller('HawkularAlerts.DefinitionsController', DefinitionsController);
 }
diff --git a/plugins/directives/plugins/sidebar/ts/sidebarPlugin.ts b/plugins/directives/plugins/sidebar/ts/sidebarPlugin.ts
@@ -15,6 +15,7 @@
 
 /// <reference path="../../includes.ts"/>
 /// <reference path="sidebarGlobals.ts"/>
+/// <reference path="sidebarDirective.ts"/>
 module Sidebar {
 
   export var _module = angular.module(pluginName, ['duScroll']);

diff --git a/plugins/directives/plugins/topbar/ts/topbarPlugin.ts b/plugins/directives/plugins/topbar/ts/topbarPlugin.ts
@@ -15,6 +15,7 @@
 
 /// <reference path="../../includes.ts"/>
 /// <reference path="topbarGlobals.ts"/>
+/// <reference path="topbarDirective.ts"/>
 module Topbar {
 
   export var _module = angular.module(pluginName, ['ngResource', 'hawkular.services', 'ui.bootstrap']);

diff --git a/plugins/directives/plugins/topbar/ts/topbarServices.ts b/plugins/directives/plugins/topbar/ts/topbarServices.ts
@@ -15,6 +15,7 @@
 
 /// <reference path="../../includes.ts"/>
 /// <reference path="topbarGlobals.ts"/>
+/// <reference path="topbarPlugin.ts"/>
 module Topbar {
 
   export class HawkularNav {

diff --git a/plugins/metrics/plugins/metrics/ts/metricsAlerts.ts b/plugins/metrics/plugins/metrics/ts/metricsAlerts.ts
@@ -52,11 +52,7 @@ module HawkularMetrics {
           return true;
         }
 
-        if ((value.start >  $scope.alertsTimeStart) && (value.start < $scope.alertsTimeEnd)) {
-          return true;
-        }
-
-        return false;
+        return !!((value.start > $scope.alertsTimeStart) && (value.start < $scope.alertsTimeEnd));
       };
 
       HawkularAlertsManager.queryConsoleAlerts(this.metricId).then((data)=> {