[RFC] Change Service associated Request type to a type parameter
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The associated constant `generic::codec::Codec::CONTENT_TYPE` is currently unused and it's not clear how it can be used to set HTTP headers. This change moves the constant to `generic::codec::Encoder::CONTENT_TYPE` and sets the header in server responses. * Move associated constant generic::codec::Codec::CONTENT_TYPE to generic::codec::Encoder * Set the content type for server responses
In relation to #79. While it may be straightforward to some that gRPC metadata can directly be set as custom headers in the HTTP2 layer, it was not to me. I think that adding it in the example may be useful to some until the `metadata` check box is ticked.
This will make it possible to store more than one client in this struct in the future, useful for the unimplemented_service test.
This test is specified in https://github.com/grpc/grpc/blob/master/doc/interop-test-descriptions.md so it should probably be here too.
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/generic-service
branch
from
14ca7da
to
fee760e
Compare
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
hawkw
force-pushed
the
eliza/generic-service
branch
from
fee760e
to
9afffe3
Compare
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
|
Closing this as the change has already been made upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in tower-rs/tower#99, this tracks the prototype
tower-rschange (hawkw/tower#1) that makesService::Requestinto a type parameter, rather than an associated type.This PR is not necessarily intended to be merged, but is opened to allow the changes to be discussed and reviewed more easily.