[RFC] Change Service associated Request type to a type parameter
#1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
Signed-off-by: Eliza Weisman <eliza@buoyant.io>
carllerche
reviewed
Oct 10, 2018
| @@ -367,9 +367,9 @@ impl<T, C, M> ServiceBuilder<T, C, M> { | |||
| where T: IntoResource<DefaultSerializer, ::run::LiftReqBody>, | |||
| C: IntoCatch<DefaultSerializer> + Send + 'static, | |||
| C::Catch: Send, | |||
| M: HttpMiddleware<RoutedService<T::Resource, C::Catch>, RequestBody = ::run::LiftReqBody> + Send + 'static, | |||
| M: HttpMiddleware<RoutedService<T::Resource, C::Catch>, ::run::LiftReqBody> + Send + 'static, | |||
There was a problem hiding this comment.
Is it possible to hide ::run::LiftReqBody from the public API with a generic request body?
|
Closing this as the change has already been made upstream. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in tower-rs/tower#99, this tracks the prototype
tower-rschange (hawkw/tower#1) that makesService::Requestinto a type parameter, rather than an associated type.This PR is not necessarily intended to be merged, but is opened to allow the changes to be discussed and reviewed more easily.