Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Headers type in IncomingMessage' #61

Closed
JbIPS opened this issue Mar 10, 2016 · 1 comment
Closed

Headers type in IncomingMessage' #61

JbIPS opened this issue Mar 10, 2016 · 1 comment

Comments

@JbIPS
Copy link
Contributor

JbIPS commented Mar 10, 2016

I saw that in recent update, Http.headers had became EitherType<String, Array<String>>, I suppose to support the set-cookie header which is an array.

But I'm wondering why this haven't been changed in IncomingMessage. Was there a compatibility issue? If not, I'll make a PR to change it as well.

Thank you
@nadako
Copy link
Member

nadako commented Mar 10, 2016

Looks like an oversight, PR welcome :)

JbIPS added a commit to JbIPS/hxnodejs that referenced this issue Mar 11, 2016
@JbIPS
Change IncomingMessage.headers to EitherType
fbcb80a 
Follow the change of API for `HttpOptions.headers` to support Array headers.

Closes HaxeFoundation#61
@JbIPS JbIPS mentioned this issue Mar 11, 2016
Merged
JbIPS added a commit to JbIPS/hxnodejs that referenced this issue Apr 7, 2016
@JbIPS
Change HttpRequestOptions.headers to DynamicAccess
ea3b1cf 
Change the type to match `HttpOptions.headers` and better access to the headers.

Same as HaxeFoundation#61
@JbIPS JbIPS mentioned this issue Apr 7, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nadako @JbIPS