Deprecate Future#fromMany (#78)

haxetink · Oct 4, 2018 · c45b90d · c45b90d
1 parent 962838a
commit c45b90d
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 2 deletions.
diff --git a/src/tink/core/Callback.hx b/src/tink/core/Callback.hx
@@ -18,8 +18,9 @@ abstract Callback<T>(T->Void) from (T->Void) {
     }
     else Callback.defer(invoke.bind(data));
 
-  // This seems useful, but most likely is not. Please create an issue if you find it useful, and don't want this cast removed.
-  @:to @:deprecated static function ignore<T>(cb:Callback<Noise>):Callback<T>
+  // This seems useful, but most likely is not. 
+  @:deprecated('Implicit cast from Callback<Noise> is deprecated. Please create an issue if you find it useful, and don\'t want this cast removed.')
+  @:to static function ignore<T>(cb:Callback<Noise>):Callback<T>
     return function (_) cb.invoke(Noise);
 
   @:from static function fromNiladic<A>(f:Void->Void):Callback<A> //inlining this seems to cause recursive implicit casts

diff --git a/src/tink/core/Future.hx b/src/tink/core/Future.hx
@@ -107,6 +107,7 @@ abstract Future<T>(FutureObject<T>) from FutureObject<T> to FutureObject<T> {
       else ret;
   }
 
+  @:deprecated('Implicit cast from Array<Future> is deprecated, please use `ofMany` instead. Please create an issue if you find it useful, and don\'t want this cast removed.')
   @:from static function fromMany<A>(futures:Array<Future<A>>):Future<Array<A>> 
     return ofMany(futures);