New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Neko tests #32

Merged

back2dos merged 4 commits into haxetink:master from benmerckx:neko_tests

Jun 11, 2016

Member

benmerckx commented Jun 11, 2016 •

edited

Loading

Adding this as a PR so it can run on travis. The tests are becoming a huge mess :) How would you like to structure this? I think we need:

Platform specific code in separate files
More feedback on what test is running/failing (use a test framework)
A way to reliably kill the server even when things go wrong (I added a try catch around the handling for mod_neko for now)

benmerckx added 4 commits

June 11, 2016 12:51


          Fix nekotools server tests

f48fefb


          Add testing for mod_neko

fd8dcd8


          Run nekotools/mod_neko on travis

b46ace5


          PHP tests leave port open

d9bf79f

back2dos merged commit 51857f7 into haxetink:master

Member

back2dos commented Jun 11, 2016

Awesome, thanks :)

back2dos mentioned this pull request

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment