Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix php header #65

Merged
merged 1 commit into from
Dec 15, 2016
Merged

Fix php header #65

merged 1 commit into from
Dec 15, 2016

Conversation

kevinresol
Copy link
Member

Closes #46

@back2dos back2dos merged commit d7f055d into haxetink:master Dec 15, 2016
@benmerckx
Copy link
Member

I don't think this one will pass cookie headers - will write a test for it later. Worst case we'll have to recreate the cookie headers from $_COOKIE. I also think checking getallheaders exists and using it if it does is a better default? Something like this:

if (untyped __call__('function_exists', 'getallheaders')) {
  var raw = php.Lib.hashOfAssociativeArray(untyped __call__('getallheaders'));
  [for (name in raw.keys()) new HeaderField(name, raw[name])];
} else ...

@kevinresol
Copy link
Member Author

I also think checking getallheaders exists and using it if it does is a better default?

Oh sure, I forgot that bit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants