feat: locations tree viewer #248
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
hay-kot
force-pushed
the
feat/tree-api
branch
from
385c197
to
5c41bb4
Compare
|
Looks pretty good. The only thing I'd change is that the tree view is sorted from A → Z. Then everything is perfect ^^. |
|
@Dxvxdffm - It was sorted but wasn't case sensitive, fixed in Though locations will still appear at the top before items in all cases. |
3 tasks
OrellBuehler
pushed a commit
to thechosenlan/homebox
that referenced
this pull request
Jun 24, 2023
* location tree API * test fixes * initial tree location elements * locations tree page * update meta-data * code-gen * store item display preferences * introduce basic table/card view elements * codegen * set parent location during location creation * add item support for tree query * refactor tree view * wip: location selector improvements * type gen * rename items -> search * remove various log statements * fix markdown rendering for description * update location selectors * fix tests * fix currency tests * formatting
OrellBuehler
pushed a commit
to thechosenlan/homebox
that referenced
this pull request
Jun 24, 2023
* location tree API * test fixes * initial tree location elements * locations tree page * update meta-data * code-gen * store item display preferences * introduce basic table/card view elements * codegen * set parent location during location creation * add item support for tree query * refactor tree view * wip: location selector improvements * type gen * rename items -> search * remove various log statements * fix markdown rendering for description * update location selectors * fix tests * fix currency tests * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a new locations tree-like view to display locations and the associated items
Closes #240
Closes #139
Currently the entire tree is returned instead of lazy loading, this happens pretty fast for what I've tested with but this may need to be improved in the future.
Navigation Bar
Tree View
Location Selector