feat/fix: search location selectors #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hay-kot
force-pushed
the
fix/search-location-selectors
branch
from
62ccf6b
to
b3607b8
Compare
OrellBuehler
pushed a commit
to thechosenlan/homebox
that referenced
this pull request
Jun 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #255
Reworks search UI to support nested location selection and cleanups up the UI quite a bit. Also fixes a search bug where Location/Label/Field queries were not applied in an expected way.
Now item results must have 1 of the locations, one of the labels, and one of the fields. Before only one of any of the criteria would need to have been met.