Fix the docker run command in README.md #278
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include volume mounting, time zone, -d and better formatting
hay-kot
reviewed
Feb 16, 2023
| --restart unless-stopped \ | ||
| -p 3100:7745 \ | ||
| -e TZ=Europe/Bucharest \ | ||
| -v ${HOME}/.homebox:/data \ |
There was a problem hiding this comment.
Why do you think should it be a bind mount instead of a volume?
--
I'm not sure I want to advocate people use their home directory over the named volume.
Given
Line 47 in 673db41
the data should be persistent anyways
🤷
There was a problem hiding this comment.
you should mount the volume in a defined location for easy backups and access. home directory makes sense as there are the... user directories, configs and data. all backup solutions include the home directory by default.
if you really don't want to use the home directory as example, you can use -v /path/to/data/folder:/data \ in the docker run, like linuxserver guys do it.
hay-kot
added a commit
that referenced
this pull request
Mar 21, 2023
* fix potential memory leak with time.After * add new background service to manage scheduled notifications * update docs * remove old js reference * closes #278 * tidy
OrellBuehler
pushed a commit
to thechosenlan/homebox
that referenced
this pull request
Jun 24, 2023
* fix potential memory leak with time.After * add new background service to manage scheduled notifications * update docs * remove old js reference * closes hay-kot#278 * tidy
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
Include volume mounting, time zone,
-dand better formatting in the README.mdWhich issue(s) this PR fixes:
none
Release Notes