Fixed 3 places where API URLs were not constructed by function route #451

db8200 · 2023-05-14T02:03:14Z

What type of PR is this?

Fix

What this PR does / why we need it:

When assembling a URL to connect to the API, the route function has to be called. This way, there is only one place where API host and API prefix are written in the code.
A few typos were corrected.

Testing

I checked that the API server was correctly responding when setting a different host name, specifically for the 3 places where I changed the URL construction (label generator, QR code and attachments).

Release Notes

API host can now be changed at a single place: frontend/lib/api/base/urls.ts

…path, params).

) * Fixed 3 places where API URLs were not constructed by function route(path, params). * autofix --------- Co-authored-by: Hayden <64056131+hay-kot@users.noreply.github.com> Former-commit-id: 06eb6c1

db8200 and others added 2 commits July 22, 2023 23:07

Fixed 3 places where API URLs were not constructed by function route(…

b8157f5

…path, params).

autofix

399239f

hay-kot force-pushed the main branch from 1506cad to 399239f Compare July 23, 2023 04:07

hay-kot merged commit 06eb6c1 into hay-kot:main Jul 23, 2023
3 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixed 3 places where API URLs were not constructed by function route #451

Fixed 3 places where API URLs were not constructed by function route #451

db8200 commented May 14, 2023 •

edited

Fixed 3 places where API URLs were not constructed by function route #451

Fixed 3 places where API URLs were not constructed by function route #451

Conversation

db8200 commented May 14, 2023 • edited

What type of PR is this?

What this PR does / why we need it:

Testing

Release Notes

db8200 commented May 14, 2023 •

edited