feat: WebSocket based implementation of server sent events for cache busting #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ations of mutation
hay-kot
force-pushed
the
feat/server-side-ws-cache-buster
branch
from
4944664
to
1df47ef
Compare
|
@hay-kot Version: v0.10.1 |
hay-kot
added a commit
that referenced
this pull request
Jan 28, 2024
…busting (#527) * rough implementation of WS based event system for server side notifications of mutation * fix test construction * fix deadlock on event bus * disable linter error * add item mutation events * remove old event bus code * refactor event system to use composables * refresh items table when new item is added * fix create form errors * cleanup unnecessary calls * fix importer erorrs + limit fn calls on import Former-commit-id: 2cbcc8b
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To Do's
What type of PR is this?
What this PR does / why we need it:
This PR implements several layers necessary to properly cache bust the frontend Labels and Locations cache on a mutation made in the database. Procedure works like so.
In the event of a performance problem down the line, we can implement passing data over the WS connection to avoid the extra call, but I don't think we'll every get to that point.
On the backend the Repository Layer will publish mutation events whenever the Locations or Labels tables are updated. It will also provide the GID as a context value.
Which issue(s) this PR fixes:
Fixes #50
Special notes for your reviewer:
Currently in rough draft status, needs another refactor to cleanup code.