Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s): spelling mistakes, and external link handling on login page #65

Merged
merged 3 commits into from
Oct 14, 2022
Merged

fix(s): spelling mistakes, and external link handling on login page #65

merged 3 commits into from
Oct 14, 2022

Conversation

Motordom
Copy link
Contributor

@Motordom Motordom commented Oct 14, 2022

What type of PR is this?

  • bug

What this PR does / why we need it:

homebox\frontend\pages\item[id]\index.vue

homebox\frontend\pages\index.vue

homebox\frontend\pages\items.vue

Which issue(s) this PR fixes:

Fixes #64
Fixes #66
Fixed #67

Release Notes


- Resolved spelling error for Model Number on item page
- Updated Discord and Docs links to open in new tabs/windows, following the behaviour of the GitHub and Twitter links on the login page
- Resolved spelling error for second occurrence of Labels in the filter section on the items page, changing it to Locations

Fix spelling mistake, changed 'Mode Number' to 'Model Number'
Updated the external links on the login page for Discord and application docs to open in new tabs/windows.
@Motordom Motordom changed the title Fix spelling mistake on items page Resolve spelling mistake on items page, and improve external link handling Oct 14, 2022
Fix spelling mistake, changed second incorrect occurrence of 'Labels' to 'Locations'
@Motordom Motordom changed the title Resolve spelling mistake on items page, and improve external link handling Resolve spelling mistakes on item and items page, and improve external link handling on login page Oct 14, 2022
@hay-kot hay-kot changed the title Resolve spelling mistakes on item and items page, and improve external link handling on login page fix(s): spelling mistakes, and external link handling on login page Oct 14, 2022
@hay-kot hay-kot merged commit b87cdc8 into hay-kot:main Oct 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants