Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix/feat: primary photo auto set and auto-set primary photo #651

Merged
merged 3 commits into from
Dec 1, 2023

Conversation

hay-kot
Copy link
Owner

@hay-kot hay-kot commented Dec 1, 2023

What type of PR is this?

(REQUIRED)

  • bug
  • feature

What this PR does / why we need it:

(REQUIRED)

Fixes issue when item has attachments but no photos. Also adds support for auto-detecting images when uploading attachments with no type. Automatically sets first image to primary image.

Which issue(s) this PR fixes:

(REQUIRED)

Closes #633

Special notes for your reviewer:

(fill-in or delete this section)

Testing

(fill-in or delete this section)

Release Notes

(REQUIRED)

@hay-kot hay-kot merged commit 321a83b into main Dec 1, 2023
3 checks passed
truecharts-admin added a commit to truecharts/charts that referenced this pull request Jan 8, 2024
…3@b1fbca6 by renovate (#16992)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/hay-kot/homebox](https://togithub.com/hay-kot/homebox) |
patch | `v0.10.2` -> `v0.10.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>hay-kot/homebox (ghcr.io/hay-kot/homebox)</summary>

###
[`v0.10.3`](https://togithub.com/hay-kot/homebox/releases/tag/v0.10.3)

[Compare
Source](https://togithub.com/hay-kot/homebox/compare/v0.10.2...v0.10.3)

#### Important Notes

- If you are having issues with authentication, logging-in, or
unexpected 404s clear your browser cache/cookies for the site.

#### What's Changed

- feat: set version flag by
[@&#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#632
- Fix a bunch of grammar and spelling, rephrased some sentences to be
more readable by
[@&#8203;kevinholtkamp](https://togithub.com/kevinholtkamp) in
[hay-kot/homebox#635
- chore(deps): update dependency mkdocs-material to v9.4.14 - autoclosed
by [@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#630
- chore(deps): update goreleaser/goreleaser-action action to v5 by
[@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#626
- chore(deps): update docker/setup-qemu-action action to v3 by
[@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#625
- fix/feat: primary photo auto set and auto-set primary photo by
[@&#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#651
- fix: loading causing stale data to present in form by
[@&#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#650
- fix: ignore /api paths from service workers by
[@&#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#649
- fix(deps): update module github.com/hay-kot/httpkit to v0.0.5 by
[@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#643
- fix(deps): update module golang.org/x/crypto to v0.16.0 - autoclosed
by [@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#645
- fix(deps): update github.com/gocarina/gocsv digest to
[`b87c2d0`](https://togithub.com/hay-kot/homebox/commit/b87c2d0) by
[@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#629
- chore(deps): update dependency mkdocs-material to v9.5.2 by
[@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#654
- chore(deps): update actions/setup-go action to v5 by
[@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#653
- chore(deps): update dependency vitest to v1 by
[@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#652
- fix(deps): update dependency markdown-it to v14 by
[@&#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#655
- feat: extract auth into provider by
[@&#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#663
- fix: ensure rows are closed by
[@&#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#670
- feat: add log statements + remove auto redirect by
[@&#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#671
- Render newlines in markdown fields by
[@&#8203;zebrapurring](https://togithub.com/zebrapurring) in
[hay-kot/homebox#682
- fix: inaccurate 401 & sql busy error by
[@&#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#679

#### New Contributors

- [@&#8203;kevinholtkamp](https://togithub.com/kevinholtkamp) made their
first contribution in
[hay-kot/homebox#635
- [@&#8203;zebrapurring](https://togithub.com/zebrapurring) made their
first contribution in
[hay-kot/homebox#682

**Full Changelog**:
hay-kot/homebox@v0.10.2...v0.10.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjYuMiIsInVwZGF0ZWRJblZlciI6IjM3LjEyNi4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
hay-kot added a commit that referenced this pull request Jan 28, 2024
* fix error when item doesn't have photo attachment

* automatically detect image types and set primary photo if first

* remove charts.js from libs

Former-commit-id: 321a83b
GabrielBarzen pushed a commit to GabrielBarzen/charts that referenced this pull request Feb 2, 2024
…3@b1fbca6 by renovate (truecharts#16992)

This PR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [ghcr.io/hay-kot/homebox](https://togithub.com/hay-kot/homebox) |
patch | `v0.10.2` -> `v0.10.3` |

---

> [!WARNING]
> Some dependencies could not be looked up. Check the Dependency
Dashboard for more information.

---

### Release Notes

<details>
<summary>hay-kot/homebox (ghcr.io/hay-kot/homebox)</summary>

###
[`v0.10.3`](https://togithub.com/hay-kot/homebox/releases/tag/v0.10.3)

[Compare
Source](https://togithub.com/hay-kot/homebox/compare/v0.10.2...v0.10.3)

#### Important Notes

- If you are having issues with authentication, logging-in, or
unexpected 404s clear your browser cache/cookies for the site.

#### What's Changed

- feat: set version flag by
[@&truecharts#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#632
- Fix a bunch of grammar and spelling, rephrased some sentences to be
more readable by
[@&truecharts#8203;kevinholtkamp](https://togithub.com/kevinholtkamp) in
[hay-kot/homebox#635
- chore(deps): update dependency mkdocs-material to v9.4.14 - autoclosed
by [@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#630
- chore(deps): update goreleaser/goreleaser-action action to v5 by
[@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#626
- chore(deps): update docker/setup-qemu-action action to v3 by
[@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#625
- fix/feat: primary photo auto set and auto-set primary photo by
[@&truecharts#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#651
- fix: loading causing stale data to present in form by
[@&truecharts#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#650
- fix: ignore /api paths from service workers by
[@&truecharts#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#649
- fix(deps): update module github.com/hay-kot/httpkit to v0.0.5 by
[@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#643
- fix(deps): update module golang.org/x/crypto to v0.16.0 - autoclosed
by [@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#645
- fix(deps): update github.com/gocarina/gocsv digest to
[`b87c2d0`](https://togithub.com/hay-kot/homebox/commit/b87c2d0) by
[@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#629
- chore(deps): update dependency mkdocs-material to v9.5.2 by
[@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#654
- chore(deps): update actions/setup-go action to v5 by
[@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#653
- chore(deps): update dependency vitest to v1 by
[@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#652
- fix(deps): update dependency markdown-it to v14 by
[@&truecharts#8203;renovate](https://togithub.com/renovate) in
[hay-kot/homebox#655
- feat: extract auth into provider by
[@&truecharts#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#663
- fix: ensure rows are closed by
[@&truecharts#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#670
- feat: add log statements + remove auto redirect by
[@&truecharts#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#671
- Render newlines in markdown fields by
[@&truecharts#8203;zebrapurring](https://togithub.com/zebrapurring) in
[hay-kot/homebox#682
- fix: inaccurate 401 & sql busy error by
[@&truecharts#8203;hay-kot](https://togithub.com/hay-kot) in
[hay-kot/homebox#679

#### New Contributors

- [@&truecharts#8203;kevinholtkamp](https://togithub.com/kevinholtkamp) made their
first contribution in
[hay-kot/homebox#635
- [@&truecharts#8203;zebrapurring](https://togithub.com/zebrapurring) made their
first contribution in
[hay-kot/homebox#682

**Full Changelog**:
hay-kot/homebox@v0.10.2...v0.10.3

</details>

---

### Configuration

📅 **Schedule**: Branch creation - "before 10pm on monday" in timezone
Europe/Amsterdam, Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Renovate
Bot](https://togithub.com/renovatebot/renovate).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4xMjYuMiIsInVwZGF0ZWRJblZlciI6IjM3LjEyNi4yIiwidGFyZ2V0QnJhbmNoIjoibWFzdGVyIn0=-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Set Primary Photos tool error - ent: attachment not found
1 participant