Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't delete recipe after changing name #67

Closed
mrherman opened this issue Jan 11, 2021 · 4 comments
Closed

Can't delete recipe after changing name #67

mrherman opened this issue Jan 11, 2021 · 4 comments

Comments

@mrherman
Copy link

After importing a recipe via URL, then changing the name of the recipe via the edit I can not delete the recipe via the edit->trash can. It asks for confirm, and acts like it works but the recipe is still there after refreshing the page.

Steps to reproduce:
Import a recipe, I used: https://steamykitchen.com/10989-indian-dal-nirvana.html
Edit the recipe and change the name: I removed the "(Dal Makhani)" part of the title.
Save the recipe
Edit recipe again, and delete.
Refresh home page and see recipe still there.

I was on version v0.0.2

@mrherman
Copy link
Author

Also can't edit the recipe after changing the name.

@mrherman
Copy link
Author

Some further testing (and without looking at the code) I would guess this is caused because mealie uses the recipe name to generate the id (or slug) which is used to store/identify the recipe. But since the name can be changed (as it should) this causes an issue since the id/slug remains the same (as it probably should, but I guess it doesn't need to).

The solution is probably to pass around a unique identifier for recipes instead of using the name (which can be changed).

@hay-kot
Copy link
Collaborator

hay-kot commented Jan 11, 2021

I'm aware of the underlying issue that's causing these problems. It came up during a major refactoring of the database interaction layer. I'm in the depths of that so an update that fixes this may not be out for a few days. Currently targeting Friday/Saturday. Thanks for your insight!

@hay-kot
Copy link
Collaborator

hay-kot commented Jan 18, 2021

This has been addressed in v0.1.0

@hay-kot hay-kot closed this as completed Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants