Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NodeJS v12 with NodeJS v16 #14

Merged
merged 1 commit into from
Dec 28, 2021

Conversation

KengoTODA
Copy link
Contributor

Hi 馃憢
Thanks for sharing your awesome GitHub Action! I'm using this to integrate SonarQube analysis with pull_request_target event.

I found that this action uses NodeJS v12 (Erbium) for now, which will end its support next April.

According to actions/runner#772 now GitHub Actions can run on NodeJS v16 (Gallium). So this PR suggests migrating to NodeJS v16. It also contains several related changes:

Thanks for checking my PR! 馃憢

"@typescript-eslint/explicit-function-return-type": ["error", {"allowExpressions": true}],
"@typescript-eslint/func-call-spacing": ["error", "never"],
"@typescript-eslint/generic-type-naming": ["error", "^[A-Z][A-Za-z]*$"],
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

generic-type-naming was replaced by naming-convention

https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0

"camelcase": "off",
"@typescript-eslint/camelcase": "error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@@ -16,13 +16,13 @@
"@typescript-eslint/no-require-imports": "error",
"@typescript-eslint/array-type": "error",
"@typescript-eslint/await-thenable": "error",
"@typescript-eslint/ban-ts-ignore": "error",
Copy link
Contributor Author

@KengoTODA KengoTODA Dec 23, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"camelcase": "off",
"@typescript-eslint/camelcase": "error",
"@typescript-eslint/class-name-casing": "error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

class-name-casing was replaced by naming-convention

https://github.com/typescript-eslint/typescript-eslint/releases/tag/v3.0.0

@@ -32,15 +32,13 @@
"@typescript-eslint/no-misused-new": "error",
"@typescript-eslint/no-namespace": "error",
"@typescript-eslint/no-non-null-assertion": "warn",
"@typescript-eslint/no-object-literal-type-assertion": "error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no-object-literal-type-assertion has merged into consistent-type-assertions.

https://github.com/typescript-eslint/typescript-eslint/releases/tag/v2.0.0

"@typescript-eslint/no-unnecessary-qualifier": "error",
"@typescript-eslint/no-unnecessary-type-assertion": "error",
"@typescript-eslint/no-useless-constructor": "error",
"@typescript-eslint/no-var-requires": "error",
"@typescript-eslint/prefer-for-of": "warn",
"@typescript-eslint/prefer-function-type": "warn",
"@typescript-eslint/prefer-includes": "error",
"@typescript-eslint/prefer-interface": "error",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Owner

@haya14busa haya14busa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR! 馃憤

@haya14busa haya14busa merged commit c69871f into haya14busa:master Dec 28, 2021
@github-actions
Copy link

馃殌 [bumpr] Bumped! New version:v1.1.0 Changes:v1.0.2...v1.1.0

@KengoTODA KengoTODA deleted the update-node-to-16 branch December 28, 2021 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants