Doghouse server is broken after Github API changes

[josephbergevin]

I am trying to run golint on a subdirectory in my repo using this command:

golint -set_exit_status ./pkg/... | reviewdog -f=golint -diff="git diff origin/master" -reporter=github-pr-check

But it is giving me a 422 Invalid request error - along with the message: "annotation_level", "path" weren't supplied. []

I can get this to run successfully by changing my command to this:

cd pkg && golint -set_exit_status ./... | reviewdog -f=golint -diff="git diff origin/master" -reporter=github-pr-check

But then the links referenced in the errors don't include the pkg folder, so they don't work.

I there a reviewdog flag I need to include to be able to make one of the above run commands work properly?

[cupakromer]

Started getting this today too for Ruby / Rails projects. Looks like it's an issue with a change in the github API.

[josephbergevin]

Oh, interesting. Is there a specific issue filed?

[cupakromer]

Well I think this may be it for reviewdog. Otherwise, digging around I see that the current GitHub v3 API for checks lists annotation_level and path as required fields for an annotation object.

Looks like changes were announced via the GitHub blog on 2018-08-16 and stated to take effect just the other day on the 27th (2018-08-27).

I think these are the change which caused the issue:

• filename is being renamed to path
• warning_level is being renamed to annotation_level

[josephbergevin]

I wonder why those are not being renamed when the linter is run on the project directory...

[josephbergevin]

@haya14busa wondering if I can get your take on this 422 Invalid request error popping up...

[ruudk]

Getting the same issue today. When the checks report issues that are filtered (outside git diff) it does work. But when they are part of the git diff, it breaks.

[ruudk]

@josephbergevin Can you change the title of this issue? Something like "Doghouse server is broken after Github API changes"

[ruudk]

Btw, if the server code of Doghouse were to be open source, we could fix this issue 💪 ;)

[josephbergevin]

Yeah I came to the same roadblock. The fix definitely needs to happen in the doghouse server code.

[haya14busa]

I'm sincerely sorry for the very late response. I fixed it today so it should work fine now.