Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] Socket delimiter #4

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[CI] Socket delimiter #4

wants to merge 2 commits into from

Conversation

haya14busa
Copy link
Owner

No description provided.

@haya14busa
use \n as delimiter for ch_evalexpr() and ch_sendexpr()
eaa2ad1 
Problem: it's difficult for server to parse messages from ch_evalexpr() and ch_sendexpr()
with json type because server may receive two messages concatenated like
this. [1,"hello!"][2,"hello!"]

Solution: use \n as delimiter
@haya14busa
fix channel_test: use \n as a delimiter
e140240
@coveralls
Copy link

coveralls commented Aug 23, 2016 •
edited
Loading

Coverage Status

Changes Unknown when pulling e140240 on socket-delimiter into * on master*.

1 similar comment
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling e140240 on socket-delimiter into * on master*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@haya14busa @coveralls