refactor(block.ts): insert SCHEDULED string as the second line in a block
#306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Someone is attempting to deploy a commit to the Hayden's projects Team on Vercel. A member of the Team first needs to authorize it. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 8, 2024
## [3.10.3](v3.10.2...v3.10.3) (2024-04-08) ### Bug Fixes * **block.ts:** insert scheduled error when block has multiple lines ([#306](#306)) ([9ede498](9ede498))
|
🎉 This PR is included in version 3.10.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
to e-zz/logseq-plugin-agenda
that referenced
this pull request
Apr 8, 2024
# [3.10.0](v3.9.2...v3.10.0) (2024-04-08) ### Bug Fixes * 🐛 aoto siwtch theme when logseq's theme changed ([haydenull#301](https://github.com/e-zz/logseq-plugin-agenda/issues/301)) ([e9fcb8d](e9fcb8d)) * **block.ts:** insert scheduled error when block has multiple lines ([haydenull#306](https://github.com/e-zz/logseq-plugin-agenda/issues/306)) ([9ede498](9ede498)) * invalid duration string `DURATION:PT` ([haydenull#294](https://github.com/e-zz/logseq-plugin-agenda/issues/294)) ([70a780b](70a780b)) ### Features * ✨ add dark theme ([haydenull#300](https://github.com/e-zz/logseq-plugin-agenda/issues/300)) ([fa8fd6c](fa8fd6c)) * shortcuts ([7a09812](7a09812)) * start of week ([c213283](c213283))
github-actions bot
pushed a commit
to e-zz/logseq-plugin-agenda
that referenced
this pull request
Jul 22, 2024
# [3.10.0](v3.9.2...v3.10.0) (2024-07-22) ### Bug Fixes * 🐛 added toast for empty task name ([e16817b](e16817b)) * 🐛 aoto siwtch theme when logseq's theme changed ([haydenull#301](https://github.com/e-zz/logseq-plugin-agenda/issues/301)) ([e9fcb8d](e9fcb8d)) * 🐛 nOW task transfer to TODO task ([d74454c](d74454c)), closes [haydenull#262](https://github.com/e-zz/logseq-plugin-agenda/issues/262) * 🐛 update task status after switch status in task modal ([952c880](952c880)), closes [haydenull#284](https://github.com/e-zz/logseq-plugin-agenda/issues/284) * `navToLogseqBlock` fails for long pages ([290970d](290970d)) * **agenda2:** 🐛 parse todoist id error ([ee1d301](ee1d301)) * **agenda2:** 🐛 prevent the sync todoist button from being clicked repeatedly ([haydenull#315](https://github.com/e-zz/logseq-plugin-agenda/issues/315)) ([3183201](3183201)), closes [haydenull#312](https://github.com/e-zz/logseq-plugin-agenda/issues/312) * **block.ts:** insert scheduled error when block has multiple lines ([haydenull#306](https://github.com/e-zz/logseq-plugin-agenda/issues/306)) ([9ede498](9ede498)) * **calendar:** 🐛 show deadline in week view ([6a43384](6a43384)) * **calendar:** 🐛 timed event from previous day causes incorrect +more count in calendar ([4ba6942](4ba6942)), closes [haydenull#316](https://github.com/e-zz/logseq-plugin-agenda/issues/316) * invalid duration string `DURATION:PT` ([haydenull#294](https://github.com/e-zz/logseq-plugin-agenda/issues/294)) ([70a780b](70a780b)) * **kanban:** 🐛 some tasks are hidden in kanban ([haydenull#314](https://github.com/e-zz/logseq-plugin-agenda/issues/314)) ([e39fe12](e39fe12)) ### Features * ✨ add dark theme ([haydenull#300](https://github.com/e-zz/logseq-plugin-agenda/issues/300)) ([fa8fd6c](fa8fd6c)) * **calendar:** ✨ show days to deadline ([5fabaec](5fabaec)) * **calendar:** ✨ show deadline task in calendar ([ed5e060](ed5e060)) * **kanban:** ✨ show deadline in kanban ([86ed350](86ed350)) * **settings:** ✨ support specify logseq api config in web [skip ci] ([7cffbee](7cffbee)) * shortcuts for agenda v3 ([haydenull#297](https://github.com/e-zz/logseq-plugin-agenda/issues/297)) ([790be0d](790be0d)) * support set start of the week ([haydenull#296](https://github.com/e-zz/logseq-plugin-agenda/issues/296)) ([b87a00e](b87a00e))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves the issue where the date-time string is appended to the end of a block even when the block has more than one line. For instance: after arraning the following task in the calendar view (either by drag-and-drop or by manual input)
- TODO test $test$the
SCHEDULEDstring will be added to the very endThe correct method is to place the string on the second line rather than at the end to ensure it is parsed correctly. Here is the result after applying the fix.