[BUG] --nodelete does not seem to work #60
Labels
bug
Something isn't working
Comments
|
Packer was not passing the no delete flag to themekit. I also created basic theme info output so you know what the settings are when you deploy |
|
@hayes0724 |
github-actions bot
pushed a commit
that referenced
this issue
Apr 26, 2021
# 1.0.0 (2021-04-26) ### Bug Fixes * --nodelete flag not checked before deploying ([c32b8ef](c32b8ef)), closes [#60](#60) * added missing dependency eslint ([b424792](b424792)) * asset generator filename ([b27eeed](b27eeed)) * catch unhandled exception on deploy in progress ([2414e65](2414e65)) * changed devtool to eval-source-map for hmr ([c8ebe24](c8ebe24)) * dev server not detecting liquid file changes ([9b1f640](9b1f640)) * fixed issue with empty config files and webpack merge ([eba227c](eba227c)) * init command extract releases that use v in tag name ([afff163](afff163)) * init theme extraction issue ([00a6388](00a6388)) * liquid styles for development ([2ad2710](2ad2710)) * packer init hanging during extraction ([4954e73](4954e73)), closes [#67](#67) * remove html encoding from html webpack filenames ([34650c0](34650c0)) * replace all special charcters in script names ([ce3da66](ce3da66)) * show error instead of exiting on deploy exception ([6d0107f](6d0107f)) * ssl check if folder exists before creating keys ([79b4223](79b4223)) * typo in config name for eslint and stylelint ([69310ac](69310ac)) * updated development asset handling ([b0213b7](b0213b7)) * webpack 5 hot middleware ([056677d](056677d)) * **html-webpack:** fixed style tag generator typo ([a23064a](a23064a)) * **packer-config:** config keys set as strings ([42fc6e2](42fc6e2)) * **packer-config:** env value live for allowing live theme deploy ([0fadb19](0fadb19)) * **packer-help:** Fixed help table rendering ([0656149](0656149)) * **packer-theme:** theme:download command typo in ignored files ([4ff8eb6](4ff8eb6)), closes [#18](#18) * **webpack-config:** Clean webpack removes entire dist folder before build ([a7dce12](a7dce12)) ### Code Refactoring * all configurations files combined ([7648d05](7648d05)) ### Features * added default cache group ([0810d9d](0810d9d)) * Added reload delay setting ([f09af05](f09af05)) * added shared bundles configuration ([7c0a23b](7c0a23b)) * Check for certificate extensions instead of fixed filename ([71789a1](71789a1)) * clean dist folder when dev server is first launched ([de0ba11](de0ba11)) * Create self-signed ssl cert from Packer CLI ([f006d6d](f006d6d)) * Create self-signed ssl cert from Packer CLI ([98701e6](98701e6)) * dev settings asset loader for fonts and images ([467d081](467d081)) * postcss updated to v8 ([7aa3f8f](7aa3f8f)) * replace node sass with dart sass ([fff7650](fff7650)) * start/watch not detecting file changes ([bc95fc6](bc95fc6)) * webpack upgraded to v5 ([4da2837](4da2837)) * **packer-theme:** Added id flag for `theme:remove` as an alternative to env values ([12b1fde](12b1fde)) * **webpack-config:** added ts file type to babel loader ([e7e1b3a](e7e1b3a)) ### Performance Improvements * optimized assets handling, copying and cleaning ([8dc64cd](8dc64cd)) ### BREAKING CHANGES * config is now located in `packer.config.js` and `packer.env.json`
github-actions bot
pushed a commit
that referenced
this issue
Apr 26, 2021
# 1.0.0 (2021-04-26) ### Bug Fixes * --nodelete flag not checked before deploying ([c32b8ef](c32b8ef)), closes [#60](#60) * added missing dependency eslint ([b424792](b424792)) * asset generator filename ([b27eeed](b27eeed)) * catch unhandled exception on deploy in progress ([2414e65](2414e65)) * changed devtool to eval-source-map for hmr ([c8ebe24](c8ebe24)) * dev server not detecting liquid file changes ([9b1f640](9b1f640)) * fixed issue with empty config files and webpack merge ([eba227c](eba227c)) * init command extract releases that use v in tag name ([afff163](afff163)) * init theme extraction issue ([00a6388](00a6388)) * liquid styles for development ([2ad2710](2ad2710)) * packer init hanging during extraction ([4954e73](4954e73)), closes [#67](#67) * remove html encoding from html webpack filenames ([34650c0](34650c0)) * replace all special charcters in script names ([ce3da66](ce3da66)) * show error instead of exiting on deploy exception ([6d0107f](6d0107f)) * ssl check if folder exists before creating keys ([79b4223](79b4223)) * typo in config name for eslint and stylelint ([69310ac](69310ac)) * updated development asset handling ([b0213b7](b0213b7)) * webpack 5 hot middleware ([056677d](056677d)) * **html-webpack:** fixed style tag generator typo ([a23064a](a23064a)) * **packer-config:** config keys set as strings ([42fc6e2](42fc6e2)) * **packer-config:** env value live for allowing live theme deploy ([0fadb19](0fadb19)) * **packer-help:** Fixed help table rendering ([0656149](0656149)) * **packer-theme:** theme:download command typo in ignored files ([4ff8eb6](4ff8eb6)), closes [#18](#18) * **webpack-config:** Clean webpack removes entire dist folder before build ([a7dce12](a7dce12)) ### Code Refactoring * all configurations files combined ([7648d05](7648d05)) ### Features * added default cache group ([0810d9d](0810d9d)) * Added reload delay setting ([f09af05](f09af05)) * added shared bundles configuration ([7c0a23b](7c0a23b)) * Check for certificate extensions instead of fixed filename ([71789a1](71789a1)) * clean dist folder when dev server is first launched ([de0ba11](de0ba11)) * Create self-signed ssl cert from Packer CLI ([f006d6d](f006d6d)) * Create self-signed ssl cert from Packer CLI ([98701e6](98701e6)) * dev settings asset loader for fonts and images ([467d081](467d081)) * postcss updated to v8 ([7aa3f8f](7aa3f8f)) * replace node sass with dart sass ([fff7650](fff7650)) * start/watch not detecting file changes ([bc95fc6](bc95fc6)) * webpack upgraded to v5 ([4da2837](4da2837)) * **packer-theme:** Added id flag for `theme:remove` as an alternative to env values ([12b1fde](12b1fde)) * **webpack-config:** added ts file type to babel loader ([e7e1b3a](e7e1b3a)) ### Performance Improvements * optimized assets handling, copying and cleaning ([8dc64cd](8dc64cd)) ### BREAKING CHANGES * config is now located in `packer.config.js` and `packer.env.json`
github-actions bot
pushed a commit
that referenced
this issue
Apr 26, 2021
# 1.0.0 (2021-04-26) ### Bug Fixes * --nodelete flag not checked before deploying ([c32b8ef](c32b8ef)), closes [#60](#60) * added missing dependency eslint ([b424792](b424792)) * asset generator filename ([b27eeed](b27eeed)) * catch unhandled exception on deploy in progress ([2414e65](2414e65)) * changed devtool to eval-source-map for hmr ([c8ebe24](c8ebe24)) * dev server not detecting liquid file changes ([9b1f640](9b1f640)) * fixed issue with empty config files and webpack merge ([eba227c](eba227c)) * init command extract releases that use v in tag name ([afff163](afff163)) * init theme extraction issue ([00a6388](00a6388)) * liquid styles for development ([2ad2710](2ad2710)) * packer init hanging during extraction ([4954e73](4954e73)), closes [#67](#67) * remove html encoding from html webpack filenames ([34650c0](34650c0)) * replace all special charcters in script names ([ce3da66](ce3da66)) * show error instead of exiting on deploy exception ([6d0107f](6d0107f)) * ssl check if folder exists before creating keys ([79b4223](79b4223)) * typo in config name for eslint and stylelint ([69310ac](69310ac)) * updated development asset handling ([b0213b7](b0213b7)) * webpack 5 hot middleware ([056677d](056677d)) * **html-webpack:** fixed style tag generator typo ([a23064a](a23064a)) * **packer-config:** config keys set as strings ([42fc6e2](42fc6e2)) * **packer-config:** env value live for allowing live theme deploy ([0fadb19](0fadb19)) * **packer-help:** Fixed help table rendering ([0656149](0656149)) * **packer-theme:** theme:download command typo in ignored files ([4ff8eb6](4ff8eb6)), closes [#18](#18) * **webpack-config:** Clean webpack removes entire dist folder before build ([a7dce12](a7dce12)) ### Code Refactoring * all configurations files combined ([7648d05](7648d05)) ### Features * added default cache group ([0810d9d](0810d9d)) * Added reload delay setting ([f09af05](f09af05)) * added shared bundles configuration ([7c0a23b](7c0a23b)) * Check for certificate extensions instead of fixed filename ([71789a1](71789a1)) * clean dist folder when dev server is first launched ([de0ba11](de0ba11)) * Create self-signed ssl cert from Packer CLI ([f006d6d](f006d6d)) * Create self-signed ssl cert from Packer CLI ([98701e6](98701e6)) * dev settings asset loader for fonts and images ([467d081](467d081)) * postcss updated to v8 ([7aa3f8f](7aa3f8f)) * replace node sass with dart sass ([fff7650](fff7650)) * start/watch not detecting file changes ([bc95fc6](bc95fc6)) * webpack upgraded to v5 ([4da2837](4da2837)) * **packer-theme:** Added id flag for `theme:remove` as an alternative to env values ([12b1fde](12b1fde)) * **webpack-config:** added ts file type to babel loader ([e7e1b3a](e7e1b3a)) ### Performance Improvements * optimized assets handling, copying and cleaning ([8dc64cd](8dc64cd)) ### BREAKING CHANGES * config is now located in `packer.config.js` and `packer.env.json`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
When doing
packer deploy --nodelete, everything gets replaced by the build.So ignored files are deleted, this includes the settings_data.json
The text was updated successfully, but these errors were encountered: