Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Deleting Liquid files breaks development #91

Closed
jzelaya-manduka opened this issue Apr 30, 2021 · 2 comments
Closed

[BUG] Deleting Liquid files breaks development #91

jzelaya-manduka opened this issue Apr 30, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@jzelaya-manduka
Copy link

Describe the bug
While packer start or packer watch is running, deleting a liquid file in the src folder causes development to break. The file in the src folder is deleted, but that same file in the dist folder still remains.

To Reproduce
Steps to reproduce the behavior:

  1. packer start
  2. create a liquid file in the src folder (e.g. src/snippets/product-card.liquid)
  3. Delete the newly created file
  4. See error

Expected behavior
Deleting a liquid file under any subdirectory in the src folder should also delete the file in the dist folder and upload the change to Shopify.

Screenshots
Screen Shot 2021-04-30 at 3 59 17 PM

System (please complete the following information):

  • OS: Mac OSX 11.3
  • Node Version v12.22.1
  • NPM Version 6.14.12
  • Browser chrome 90.0.4430.93

Packer (please complete the following information):

  • Version v2.1.5

Theme (please complete the following information):

@jzelaya-manduka jzelaya-manduka added the bug Something isn't working label Apr 30, 2021
@hayes0724
Copy link
Owner

@jzelaya-manduka This has been fixed in v2.1.9

@jzelaya-manduka
Copy link
Author

@hayes0724 I've upgraded to v2.2.0 and I no longer see the error in the console and deleted files in the dist folder are now removed as intended. However after running packer start and then adding and deleting the file, the deleted file in the dist folder doesn't trigger an update to remove it from Shopify. Is this the expected behavior?

Screen Shot 2021-05-03 at 10 00 00 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants