-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Helen/add forgot password with reset link (new) #52
Merged
JumanaFM
merged 3 commits into
haystack:master
from
lihelennn:helen/add-forgot-password-2
Dec 20, 2020
Merged
Helen/add forgot password with reset link (new) #52
JumanaFM
merged 3 commits into
haystack:master
from
lihelennn:helen/add-forgot-password-2
Dec 20, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JumanaFM
approved these changes
Dec 20, 2020
Not urgent, but these reset links should expire after a relatively short
period (a day, or an hour), even if never used.
…On 12/18/2020 6:57 PM, Helen Li wrote:
Adding appropriate frontend and backend changes to allow user to get a
reset password link to change their password
1. A user will enter their email into the "Forgot Password" field and
be emailed a link to reset their password
2. If the user clicks on the link, they will be logged in and
navigated to the profile page to set their password
3. After a user logs in, the link no longer be able to access the
user's account
Notes:
* There is a migration involved to add a |reset_password_id| so we
know when to redirect a user to their logged in settings page. Do
the appropriate steps
<https://docs.google.com/document/d/1rYwcMhj4RBuJzi4SewfiY3BmNAmFKImLfwRbELBjBNk/edit>
for a migration.
* Please ask @lihelennn <https://github.com/lihelennn> for Gmail
username & password credentials (used in nodemailer in
|email-config.js|
image
<https://user-images.githubusercontent.com/8744689/102674123-ad3ff500-4149-11eb-89f9-0d9f9ef33557.png>
image
<https://user-images.githubusercontent.com/8744689/102674143-bdf06b00-4149-11eb-9842-4f1819ac8e7f.png>
------------------------------------------------------------------------
You can view, comment on, or merge this pull request online at:
#52
<#52>
Commit Summary
* Add migration file to add reset_password_id field
* Add backend and frontend support to send reset password link
* Add backend and frontend support to redirect user to reset
password settings page
File Changes
* *A* email-config.js
<https://github.com/haystack/nb/pull/52/files#diff-48020c6ea2394b286e6636a2fb3bfcad47c6c7c3e01b188b7c1e4c6550d0ca7f>
(11)
* *A* migrations/20201218201543-add-reset-password-field.js
<https://github.com/haystack/nb/pull/52/files#diff-c434cdfd4d316144513b61d49a2bdc85808ae8e91cea66470f32916da1ce3e81>
(20)
* *M* models/Users.js
<https://github.com/haystack/nb/pull/52/files#diff-d20e0c91f722f4a7eb0a8a7dfa4d7799aa292685d66aaeb37f3122ff3594fefd>
(5)
* *M* package-lock.json
<https://github.com/haystack/nb/pull/52/files#diff-053150b640a7ce75eff69d1a22cae7f0f94ad64ce9a855db544dda0929316519>
(106)
* *M* package.json
<https://github.com/haystack/nb/pull/52/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519>
(4)
* *M* routes/users.js
<https://github.com/haystack/nb/pull/52/files#diff-fc074c6d7465bef95caefa94a2b0a18d5810e2204cc399dc4dd9d7a646b13aff>
(61)
* *M* src/components/user/UserLogin.vue
<https://github.com/haystack/nb/pull/52/files#diff-f10ab6fe812a467dfa39a19f7814b8ba00fd2d8b4088f86a9f6e97671433eec3>
(43)
* *M* src/router.js
<https://github.com/haystack/nb/pull/52/files#diff-d7f41ba1aa74f41ef4b0c2337abe593d08092ffae6528a8aa2db712afeee0b66>
(7)
* *M* src/views/ProfilePage.vue
<https://github.com/haystack/nb/pull/52/files#diff-5e02ae5fba1b57b9fa5a36db77d26420aee2d8a8b446f8a174a328e2ee8e2114>
(28)
Patch Links:
* https://github.com/haystack/nb/pull/52.patch
<https://github.com/haystack/nb/pull/52.patch>
* https://github.com/haystack/nb/pull/52.diff
<https://github.com/haystack/nb/pull/52.diff>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#52>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIWSXWM5YLNI34YERWLNTDSVPUAPANCNFSM4VB2SJDQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding appropriate frontend and backend changes to allow user to get a reset password link to change their password
Notes:
reset_password_id
so we know when to redirect a user to their logged in settings page. Do the appropriate steps for a migration.email-config.js
closes #5