Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Service port name does not match port name k8s discovery is looking for in Hazelcast > 5.3.0 #371

Closed
rvaidya opened this issue Aug 8, 2023 · 1 comment · Fixed by #382

Comments

@rvaidya
Copy link

rvaidya commented Aug 8, 2023

In the official Helm chart, the service port name is "tcp-hzport"

However, the Kubernetes discovery only looks for port named "hazelcast"

https://github.com/hazelcast/hazelcast/blob/22bb38e3d806e26e614641ab6a73db73ea8132f4/hazelcast/src/main/java/com/hazelcast/kubernetes/KubernetesApiProvider.java#L54

Related:
hazelcast/hazelcast#19643
hazelcast/hazelcast#24834

@rvaidya rvaidya changed the title Service port name does not match port name k8s discovery is looking for for Hazelcast > 5.3.0 Service port name does not match port name k8s discovery is looking for in Hazelcast > 5.3.0 Aug 8, 2023
@semihbkgr
Copy link
Member

Hi @rvaidya, thank for the heads up!

If there is only one port in the service, the port name will be omitted by the Kubernetes discovery plugin.

if (ports.size() == 1) {
    JsonValue port = ports.get(0);
    return port.asObject().get("port").asInt();
}

It's not an issue in the charts, but we can fix it, though, to synchronize the default values of both the chart and the Kubernetes discovery plugin. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants