Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added client messages for map and cache partition iterator #7

Merged
merged 1 commit into from
May 24, 2016
Merged

Added client messages for map and cache partition iterator #7

merged 1 commit into from
May 24, 2016

Conversation

eminn
Copy link
Contributor

@eminn eminn commented May 18, 2016

No description provided.

@eminn eminn mentioned this pull request May 18, 2016
Merged
asimarslan
asimarslan reviewed May 18, 2016
View reviewed changes
hazelcast/src/main/java/com/hazelcast/client/impl/protocol/template/MapCodecTemplate.java
* @param batch The number of items to be batched
* @return last index processed and list of data
*/
@Request(id = 60, retryable = false, response = ResponseMessageConst.MAP_KEY_ITERATOR_RESULT, partitionIdentifier = "partitionId")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be retryable

@ihsandemir
Copy link
Collaborator

ihsandemir commented May 18, 2016 •
edited
Loading

Will we make this a part of open binary protocol? When you put these into these templates, it shall go into the published protocol. I understood that this shall be an internal message, is this possible at all? This needs to be decided. (Can we allow non-published messages flow between server and client?)

If it will be part of the published protocol, then for binary compatibility:
Need to generate the test binary resources e.g. https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/test/resources/1.0.protocol.compatibility.binary since it shall be version protocol 1.1 and put make sure that they are integrated into the tests for compatibility.

@eminn eminn force-pushed the map-partition-iterator branch 2 times, most recently from 896558b to 9663db7 Compare May 24, 2016 08:31
@eminn eminn changed the title Added client message for map partition iterator Added client messages for map and cache partition iterator May 24, 2016
@eminn
Copy link
Contributor Author

eminn commented May 24, 2016

@ihsandemir @asimarslan PR is updated, Could you guys have a final look at it ?

@ihsandemir
Copy link
Collaborator

👍

asimarslan
asimarslan reviewed May 24, 2016
View reviewed changes
hazelcast/src/main/java/com/hazelcast/client/impl/protocol/template/MapCodecTemplate.java
* @param partitionId The partition id which owns this record store.
* @param tableIndex The slot number (or index) to start the iterator
* @param batch The number of items to be batched
* @return last index processed and list of data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"List of entries" I guess

@asimarslan
Copy link
Contributor

👍

@eminn eminn merged commit 8d8e4f5 into hazelcast:master May 24, 2016
@mustafaiman mustafaiman mentioned this pull request May 30, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Type: Enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@eminn @ihsandemir @asimarslan