Added missing executeonX tests for Map. #2
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -666,19 +666,19 @@ namespace hazelcast { | |||
| * Notice that map EntryProcessor runs on the nodes. Because of that, same class should be implemented in java side | |||
| * with same classId and factoryId. | |||
| * | |||
| * @tparam EntryProcessor type of entry processor class | |||
| * @tparam ResultType that entry processor will return | |||
| * @param EntryProcessor type of entry processor class | |||
There was a problem hiding this comment.
tparam stands for template parameter, doxygen interpertes these two differently and produces different output. These should stay as tparam.
|
One minor comment. |
ihsandemir
force-pushed
the
executeOnXTests
branch
from
a617233
to
62a43f3
Compare
|
#11 includes this test and the implementation. |
This was referenced Jun 18, 2018
ihsandemir
referenced
this pull request
in ihsandemir/hazelcast-cpp-client
Nov 27, 2018
… failure: ``` 02:18:17 clientTest_SHARED_64: /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/external/include/boost/smart_ptr/shared_ptr.hpp:703: typename boost::detail::sp_dereference<T>::type boost::shared_ptr<T>::operator*() const [with T = std::string]: Assertion `px != 0' failed. 02:18:17 testLinuxSingleCase.sh: line 67: 4719 Aborted (core dumped) ... 02:18:21 Thread 1 (Thread 0x7f523b652800 (LWP 4719)): 02:18:21 #0 0x00007f52390d15e5 in raise () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 #1 0x00007f52390d2dc5 in abort () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 #2 0x00007f52390ca70e in __assert_fail_base () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 hazelcast#3 0x00007f52390ca7d0 in __assert_fail () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 hazelcast#4 0x0000000000ccbcd9 in boost::shared_ptr<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >::operator* (this=0x7ffca392d4f0) at /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/external/include/boost/smart_ptr/shared_ptr.hpp:703 02:18:21 __PRETTY_FUNCTION__ = "typename boost::detail::sp_dereference<T>::type boost::shared_ptr<T>::operator*() const [with T = std::string]" 02:18:22 hazelcast#5 0x0000000000fe7212 in hazelcast::client::test::ClientMapTest_testPutConfigTtl_Test<hazelcast::client::test::NearCachedDataMapClientConfig>::TestBody (this=0x4117ca0) at /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/hazelcast/test/src/map/ClientMapTest.cpp:709 ```
ihsandemir
referenced
this pull request
in ihsandemir/hazelcast-cpp-client
Dec 3, 2018
…mes caused test failures: ``` 02:18:17 clientTest_SHARED_64: /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/external/include/boost/smart_ptr/shared_ptr.hpp:703: typename boost::detail::sp_dereference<T>::type boost::shared_ptr<T>::operator*() const [with T = std::string]: Assertion `px != 0' failed. 02:18:17 testLinuxSingleCase.sh: line 67: 4719 Aborted (core dumped) ... 02:18:21 Thread 1 (Thread 0x7f523b652800 (LWP 4719)): 02:18:21 #0 0x00007f52390d15e5 in raise () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 #1 0x00007f52390d2dc5 in abort () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 #2 0x00007f52390ca70e in __assert_fail_base () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 hazelcast#3 0x00007f52390ca7d0 in __assert_fail () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 hazelcast#4 0x0000000000ccbcd9 in boost::shared_ptr<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >::operator* (this=0x7ffca392d4f0) at /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/external/include/boost/smart_ptr/shared_ptr.hpp:703 02:18:21 __PRETTY_FUNCTION__ = "typename boost::detail::sp_dereference<T>::type boost::shared_ptr<T>::operator*() const [with T = std::string]" 02:18:22 hazelcast#5 0x0000000000fe7212 in hazelcast::client::test::ClientMapTest_testPutConfigTtl_Test<hazelcast::client::test::NearCachedDataMapClientConfig>::TestBody (this=0x4117ca0) at /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/hazelcast/test/src/map/ClientMapTest.cpp:709 ```
ihsandemir
added a commit
that referenced
this pull request
Dec 3, 2018
* Make testPutConfigTtl less time sensitive. The current version sometimes caused test failures: ``` 02:18:17 clientTest_SHARED_64: /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/external/include/boost/smart_ptr/shared_ptr.hpp:703: typename boost::detail::sp_dereference<T>::type boost::shared_ptr<T>::operator*() const [with T = std::string]: Assertion `px != 0' failed. 02:18:17 testLinuxSingleCase.sh: line 67: 4719 Aborted (core dumped) ... 02:18:21 Thread 1 (Thread 0x7f523b652800 (LWP 4719)): 02:18:21 #0 0x00007f52390d15e5 in raise () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 #1 0x00007f52390d2dc5 in abort () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 #2 0x00007f52390ca70e in __assert_fail_base () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 #3 0x00007f52390ca7d0 in __assert_fail () from /lib64/libc.so.6 02:18:21 No symbol table info available. 02:18:21 #4 0x0000000000ccbcd9 in boost::shared_ptr<std::basic_string<char, std::char_traits<char>, std::allocator<char> > >::operator* (this=0x7ffca392d4f0) at /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/external/include/boost/smart_ptr/shared_ptr.hpp:703 02:18:21 __PRETTY_FUNCTION__ = "typename boost::detail::sp_dereference<T>::type boost::shared_ptr<T>::operator*() const [with T = std::string]" 02:18:22 #5 0x0000000000fe7212 in hazelcast::client::test::ClientMapTest_testPutConfigTtl_Test<hazelcast::client::test::NearCachedDataMapClientConfig>::TestBody (this=0x4117ca0) at /home/jenkins/jenkins/workspace/cpp-linux-nightly-64-SHARED-Debug/hazelcast/test/src/map/ClientMapTest.cpp:709 ``` * Fixed missing type usages in template method calls.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests per https://github.com/hazelcast/cpp-client/issues/112 .
executeOnKey and executeOnEntries tests for Map are added.