Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error in get_all imap method with hazelcast_json_value value type #926

Merged
merged 2 commits into from
Sep 1, 2021
Merged

Fix error in get_all imap method with hazelcast_json_value value type #926

merged 2 commits into from
Sep 1, 2021

Conversation

RikeVoltz
Copy link
Contributor

This PR closes #925

@devOpsHazelcast
Copy link
Contributor

Can one of the admins verify this patch?

1 similar comment
@devOpsHazelcast
Copy link
Contributor

Can one of the admins verify this patch?

@RikeVoltz
Copy link
Contributor Author

Hello there :)
image

@ihsandemir
Copy link
Collaborator

run-lab-run

@ihsandemir ihsandemir added this to the 5.0.0 milestone Sep 1, 2021
@ihsandemir
Copy link
Collaborator

Thanks for the PR.

ihsandemir
ihsandemir previously approved these changes Sep 1, 2021
View reviewed changes
@yemreinci
Copy link
Contributor

verify

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@RikeVoltz @yemreinci
Fix redundant copy of value in get_all imap method
0dcb613 
Co-authored-by: yemreinci <18687880+yemreinci@users.noreply.github.com>
@yemreinci
Copy link
Contributor

verify

@devOpsHazelcast
Copy link
Contributor

Windows test PASSed.

@devOpsHazelcast
Copy link
Contributor

Linux test PASSed.

@yemreinci yemreinci merged commit 12aa0dc into hazelcast:master Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihsandemir ihsandemir ihsandemir approved these changes

@yemreinci yemreinci yemreinci approved these changes

Assignees

@RikeVoltz RikeVoltz

Labels
Source: Community
Projects
None yet
Milestone
5.0.0
Development

Successfully merging this pull request may close these issues.

Error in get_all imap method with hazelcast_json_value value type
4 participants
@RikeVoltz @devOpsHazelcast @ihsandemir @yemreinci