Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invocation timeout fixed to respect long running operations #113

Merged
merged 1 commit into from
Jul 25, 2017
Merged

invocation timeout fixed to respect long running operations #113

merged 1 commit into from
Jul 25, 2017

Conversation

asimarslan
Copy link
Contributor

fixes #112

@asimarslan asimarslan added this to the 3.8.2 milestone Jul 18, 2017
@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@asimarslan
Copy link
Contributor Author

verify

1 similar comment
@asimarslan
Copy link
Contributor Author

verify

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@asimarslan
Copy link
Contributor Author

verify

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

ihsandemir
ihsandemir reviewed Jul 19, 2017
View reviewed changes
Hazelcast.Net/Hazelcast.Client.Spi/ClientInvocationService.cs
{
invocation.Future.Exception = exception;
}
catch (InvalidOperationException e)
{
if (Logger.IsFinestEnabled())
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We made this log as warning at Java: https://github.com/hazelcast/hazelcast/blob/master/hazelcast/src/main/java/com/hazelcast/spi/impl/AbstractInvocationFuture.java#L377 This may be also set as warning.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should change Java side to debug 🤔 .
There is nothing for customer can do with this log as it is only a debug message that should be reported back to us.

@asimarslan
Copy link
Contributor Author

asimarslan commented Jul 19, 2017 •
edited

Listener reregistration is broken, a separate fix will be sent. I'll ignore the failing test for now.
see:#114

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@devOpsHazelcast
Copy link
Contributor

Test FAILed.

@devOpsHazelcast
Copy link
Contributor

Test PASSed.

@asimarslan
Copy link
Contributor Author

verify

1 similar comment
@asimarslan
Copy link
Contributor Author

verify

@asimarslan
Copy link
Contributor Author

verify

@devOpsHazelcast
Copy link
Contributor

Test PASSed.

@asimarslan asimarslan merged commit 079b158 into hazelcast:maintenance-3.x Jul 25, 2017
This was referenced Jul 25, 2017
Closed
Closed
Closed
@asimarslan asimarslan deleted the ticket-2944 branch July 11, 2018 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ihsandemir ihsandemir ihsandemir left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.8.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@asimarslan @devOpsHazelcast @ihsandemir