Update SerializationService to bring it in line with Java client #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cangencer
force-pushed
the
enhancements/serialization
branch
from
e89601d
to
e23975a
Compare
| @@ -54,29 +52,6 @@ public ISerializer GetImpl() | |||
| return _serializer; | |||
| } | |||
|
|
|||
| public override bool Equals(object o) | |||
There was a problem hiding this comment.
Don't we need Equal and HashCode methods ?
There was a problem hiding this comment.
I removed them because they were not in any code path (never used)
|
What about putting the .Net default serialization in the last step as Java did. It won't be compatible with other clients but would work perfectly for .Net clients. |
cangencer
force-pushed
the
enhancements/serialization
branch
from
e23975a
to
50ab046
Compare
|
I've added support for C# Serializable now, which uses type ID -101, which probably should be added to the Java list of constants so that it's reserved. Incidentally Generic Lists in C# are serializable by default, so at least this way you can serialize/deserialize generic lists directly. |
Update default serializers to be constant, and add serializers for List and LinkedList. Add support for default CLR Serializable serialization.
cangencer
force-pushed
the
enhancements/serialization
branch
from
50ab046
to
107bc6d
Compare
|
verify |
|
verify |
|
👍 |
cangencer
added a commit
that referenced
this pull request
Nov 20, 2015
Update SerializationService to bring it in line with Java client
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update default serializers to be constant, and add serializers for List
and LinkedList