Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[API-274] SQL for Map ([API-617], [API-616], [API-431], [API-619], [API-620], [API-432], [API-659], [API-660], [API-661]) #475

Merged
merged 132 commits into from
Sep 2, 2021
Merged

[API-274] SQL for Map ([API-617], [API-616], [API-431], [API-619], [API-620], [API-432], [API-659], [API-660], [API-661]) #475

merged 132 commits into from
Sep 2, 2021

Conversation

alexb5dh
Copy link
Contributor

@alexb5dh alexb5dh commented Jun 24, 2021 •
edited

@alexb5dh alexb5dh changed the title [API-428, API-429] SQL for Map Codecs [API-428, API-429] SQL for Map - Codecs Jun 24, 2021
@alexb5dh alexb5dh changed the title [API-428, API-429] SQL for Map - Codecs [API-428, API-429, API-430] SQL for Map - Codecs Jun 29, 2021
@alexb5dh alexb5dh changed the title [API-428, API-429, API-430] SQL for Map - Codecs [API-428, API-429, API-430] SQL for Map Jul 7, 2021
@alexb5dh alexb5dh changed the title [API-428, API-429, API-430] SQL for Map [API-274] SQL for Map Jul 8, 2021
zpqrtbnk
zpqrtbnk reviewed Aug 25, 2021
View reviewed changes
Copy link
Contributor

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have commented - I still have issues with cancellations

src/Hazelcast.Net/Sql/ISqlQueryResult.cs Outdated Show resolved Hide resolved
src/Hazelcast.Net/Sql/ISqlQueryResult.cs Outdated Show resolved Hide resolved
src/Hazelcast.Net.Examples/Sql/SqlCancellationExample.cs Outdated Show resolved Hide resolved
@alexb5dh alexb5dh changed the title [API-274] SQL for Map [API-274] SQL for Map ([API-617], [API-616], [API-431], [API-619], [API-620], [API-432], [API-659], [API-660], [API-661]) Aug 29, 2021
@zpqrtbnk zpqrtbnk added Source: Internal Type: Feature Request Issue is a Feature Request. labels Aug 31, 2021
zpqrtbnk
zpqrtbnk approved these changes Sep 2, 2021
View reviewed changes
Copy link
Contributor

@zpqrtbnk zpqrtbnk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Think it's good to go now.

@alexb5dh alexb5dh merged commit 63d3246 into hazelcast:master Sep 2, 2021
@alexb5dh alexb5dh deleted the feature/sql-support branch September 2, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdumandag mdumandag mdumandag left review comments

@zpqrtbnk zpqrtbnk zpqrtbnk approved these changes

Assignees
No one assigned
Labels
Type: Feature Request Issue is a Feature Request.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@alexb5dh @srknzl @zpqrtbnk @mdumandag