Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor #245

Closed
13 tasks done
SaitTalhaNisanci opened this issue Apr 27, 2018 · 0 comments
Closed
13 tasks done

Refactor #245

SaitTalhaNisanci opened this issue Apr 27, 2018 · 0 comments
Assignees
@SaitTalhaNisanci @furkansenharputlu
Labels
Type: Cleanup Type: Enhancement
Projects
0.3
Milestone
0.3

Comments

@SaitTalhaNisanci
Copy link
Contributor

SaitTalhaNisanci commented Apr 27, 2018 •
edited
Loading

  • Make receiver names shorter
  • Fix go vet errors.
  • Make package names shorter
  • Remove unnecessary names from Methods like Hazelcast from hazelcast.NewHazelcastClient()
  • Add dot imports
  • Use goimports
  • Fix warnings from https://github.com/alecthomas/gometalinter
  • Refactor constant names to camel case
  • Remove I prefix from IMap etc
  • Remove unused interfaces
  • refactor packages such as Common
  • Fix comments
  • Remove unnecessary pointers to strings
@SaitTalhaNisanci SaitTalhaNisanci added this to To do in 0.3 via automation Apr 27, 2018
@SaitTalhaNisanci SaitTalhaNisanci added this to the 0.3 milestone Apr 27, 2018
This was referenced Apr 27, 2018
Merged
Merged
Merged
This was referenced Apr 28, 2018
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@furkansenharputlu furkansenharputlu mentioned this issue Apr 29, 2018
Closed
This was referenced May 3, 2018
Merged
Merged
0.3 automation moved this from To do to Done May 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SaitTalhaNisanci SaitTalhaNisanci

@furkansenharputlu furkansenharputlu

Labels
Type: Cleanup Type: Enhancement
Projects
No open projects
0.3
  
Done
Milestone
0.3
Development

No branches or pull requests
2 participants
@SaitTalhaNisanci @furkansenharputlu