Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove unnecessary pointers to strings #258

Merged
merged 1 commit into from
May 7, 2018
Merged

remove unnecessary pointers to strings #258

merged 1 commit into from
May 7, 2018

Conversation

SaitTalhaNisanci
Copy link
Contributor

This pr removes unnecessary pointers to strings as strings are implemented with pointers internally.

#245.

@SaitTalhaNisanci SaitTalhaNisanci added this to the 0.3 milestone May 7, 2018
@SaitTalhaNisanci SaitTalhaNisanci self-assigned this May 7, 2018
@SaitTalhaNisanci SaitTalhaNisanci added this to To do in 0.3 via automation May 7, 2018
@devOpsHazelcast
Copy link

Test FAILed.

@devOpsHazelcast
Copy link

Test PASSed.

mustafaiman
mustafaiman approved these changes May 7, 2018
View reviewed changes
Copy link
Contributor

@mustafaiman mustafaiman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requires the same fix to code-generator ASAP!!

@mustafaiman mustafaiman mentioned this pull request May 7, 2018
Closed
@SaitTalhaNisanci SaitTalhaNisanci merged commit 4ad4cce into hazelcast:master May 7, 2018
0.3 automation moved this from To do to Done May 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sancar sancar sancar approved these changes

@mustafaiman mustafaiman mustafaiman approved these changes

Assignees

@SaitTalhaNisanci SaitTalhaNisanci

Labels
Type: Cleanup Type: Enhancement
Projects
No open projects
0.3
  
Done
Milestone
0.3
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@SaitTalhaNisanci @devOpsHazelcast @sancar @mustafaiman