-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HazelcastInstanceFactory can't instantiate custom IHazelcastInstanceLoader #21
Comments
Hi @jontejj, |
We want to integrate overwriting some of the config before loading the instance. For example specifying ip:s for members in the cluster for different environments. We don't want to duplicate the config for three different environments. |
I see now that we can use .put instead of setProperty :). |
Reopening this as we ran into issues with a property being a non-string. For the sake of integrating with other libraries it's better to use best practises and not store non-strings in the properties. |
…t#21. This is better because many third-party db libraries assume that properties in Properties are Strings, not objects.
I was a bit unfamiliar with how pull requests works in github, so I'll create a PR for this when #22 has been merged. |
…t#21. This is better because many third-party db libraries assume that properties in Properties are Strings, not objects.
java.util.Properties requires values to be strings. So (IHazelcastInstanceLoader) props.get(...) does not work. Better to treat it as a class name and instantiate the factory instead.
The text was updated successfully, but these errors were encountered: