Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update compatibility tests #425

Merged
merged 6 commits into from
Jun 12, 2023
Merged

Update compatibility tests #425

merged 6 commits into from
Jun 12, 2023

Conversation

ldziedziul
Copy link
Contributor

@ldziedziul ldziedziul commented Jun 7, 2023 •
edited
Loading

  • Updates versions of Hibernate and Hazelcast used in tests
  • Drops JDK8 tests and adds JDK20
  • Fixes triggering compatibility tests against PRs with compatibility-sensitive label

@ldziedziul ldziedziul self-assigned this Jun 7, 2023
@ldziedziul ldziedziul requested a review from a team as a code owner June 7, 2023 13:29
@github-actions
Copy link

github-actions bot commented Jun 7, 2023 •
edited
Loading

Test Results

128 tests  ±0   128 ✔️ ±0   1m 5s ⏱️ -6s
  24 suites ±0       0 💤 ±0 
  24 files   ±0       0 ❌ ±0 

Results for commit 19a13c7. ± Comparison against base commit 537447f.

♻️ This comment has been updated with latest results.

frant-hartm
frant-hartm requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@frant-hartm frant-hartm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we have some explanation what was the issue causing some of the tests to fail?

.github/workflows/compatibility-tests.yml Outdated
runs-on: ubuntu-latest
strategy:
fail-fast: false
matrix:
hazelcast: [ '4.2.5', '5.0.3', '5.1.5', '5.2.1', '5.3.0-SNAPSHOT' ]
hibernate: [ '5.3.28.Final', '5.4.33.Final', '5.5.9.Final', '5.6.14.Final', '6.0.2.Final', '6.1.5.Final' ]
hazelcast: [ '5.0.4', '5.1.6', '5.2.3', '5.3.0','5.4.0-SNAPSHOT' ]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does 4.2.z have any particular issue? 4.2.z is out of support, but there are extended support contracts, if possible lets keep latest 4.2.z

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-added 19a13c7

@ldziedziul
Copy link
Contributor Author

Can we have some explanation what was the issue causing some of the tests to fail?

The fix was in the different PR, I've added explaination there: https://github.com/hazelcast/hazelcast-hibernate/pull/423/files?diff=unified&w=0#r1222049368

@ldziedziul ldziedziul enabled auto-merge (squash) June 8, 2023 09:09
@ldziedziul ldziedziul merged commit 9f1a4c8 into master Jun 12, 2023
49 checks passed
@ldziedziul ldziedziul deleted the update-compatibility-tests branch June 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frant-hartm frant-hartm frant-hartm approved these changes

@TomaszGaweda TomaszGaweda TomaszGaweda approved these changes

Assignees

@ldziedziul ldziedziul

Labels
compatibility-sensitive
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ldziedziul @frant-hartm @TomaszGaweda