Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent behaviour of mapToOutputFn in aggregation operations #837

Closed
cangencer opened this issue Apr 25, 2018 · 1 comment
Closed

Consistent behaviour of mapToOutputFn in aggregation operations #837

cangencer opened this issue Apr 25, 2018 · 1 comment
Assignees
@viliam-durina
Labels
enhancement Pipeline API
Milestone
0.7

Comments

@cangencer
Copy link
Contributor

cangencer commented Apr 25, 2018 •
edited

mapToOutputFn in aggregations should support returning null to filter out certain keys and values to make it consistent with other map and flatMap operations.

This will allow the user to filter out empty results and prevent having to create a temporary item just to filter it out later.

See related question: https://stackoverflow.com/questions/50013276/hazelcast-jet-discard-empty-aggregation-results
@viliam-durina
Copy link
Contributor

We should probably support the AggregateOperation.finishFn() to return null as well.

@cangencer cangencer added this to the 0.7 milestone May 3, 2018
viliam-durina added a commit to viliam-durina/hazelcast-jet that referenced this issue Jun 25, 2018
@viliam-durina
Consistent behaviour of mapToOutputFn
a07cb17 
Fixes hazelcast#837
@viliam-durina viliam-durina mentioned this issue Jun 25, 2018
Merged
@viliam-durina viliam-durina self-assigned this Jun 25, 2018
viliam-durina added a commit that referenced this issue Jun 28, 2018
@viliam-durina
Consistent behaviour of mapToOutputFn (#938)
2494b68 
Fixes #837
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@viliam-durina viliam-durina

Labels
enhancement Pipeline API
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
2 participants
@cangencer @viliam-durina