Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make watermarks source explicit in Pipeline API #1166

Merged
merged 23 commits into from Dec 14, 2018
Merged

Make watermarks source explicit in Pipeline API #1166

merged 23 commits into from Dec 14, 2018

Conversation

viliam-durina
Copy link
Contributor

No description provided.

@viliam-durina viliam-durina added this to the 0.8 milestone Dec 5, 2018
@viliam-durina viliam-durina self-assigned this Dec 5, 2018
@viliam-durina viliam-durina changed the title [WIP] Make watermarks source explicit in Pipeline API Make watermarks source explicit in Pipeline API Dec 6, 2018
@viliam-durina viliam-durina mentioned this pull request Dec 6, 2018
Merged
@viliam-durina viliam-durina mentioned this pull request Dec 10, 2018
Merged
@cangencer
Copy link
Contributor

  • JMS source should also include default timestamps
  • It would be better if pipeline would fail during planning stage when withDefaultTimestamps() is used but source doesn't provide default timestamps.
  • It should be documented on sources that support it what the defaultTimestamp corresponds to.

@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from viliam-durina Dec 14, 2018
@hazelcast hazelcast deleted a comment from viliam-durina Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@hazelcast hazelcast deleted a comment from devOpsHazelcast Dec 14, 2018
@viliam-durina viliam-durina merged commit 9e83bd5 into hazelcast:master Dec 14, 2018
@viliam-durina viliam-durina deleted the explicit-watermarks branch December 14, 2018 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mtopolnik mtopolnik mtopolnik approved these changes

@cangencer cangencer cangencer approved these changes

Assignees

@viliam-durina viliam-durina

Labels
breaking-change Pipeline API
Projects
None yet
Milestone
3.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@viliam-durina @cangencer @mtopolnik