Remove max-retain and policies #1184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-retain # Conflicts: # hazelcast-jet-core/src/main/java/com/hazelcast/jet/core/WatermarkEmissionPolicy.java # hazelcast-jet-core/src/test/java/com/hazelcast/jet/core/Processors_slidingWindowingIntegrationTest.java
viliam-durina
changed the title
|
Test FAILed. |
…ve to implement idle timeout and wrapping
This was referenced Dec 20, 2018
mtopolnik
reviewed
Jan 7, 2019
| @@ -190,6 +185,18 @@ static String uniqueName( | |||
| } | |||
| } | |||
|
|
|||
| /** | |||
| * Returns new instance with emit policy replaced with the | |||
| /** | ||
| * Special-case implementation for zero inputs (source processors). | ||
| */ | ||
| private static final class SingleInputImpl extends WatermarkCoalescer { |
There was a problem hiding this comment.
Is it zero inputs or single input? Either Javadoc or class name is wrong.
mtopolnik
approved these changes
Jan 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.