Implement exclusive job execution #1203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test FAILed. |
|
Test FAILed. |
viliam-durina
suggested changes
Jan 17, 2019
hazelcast-jet-core/src/main/java/com/hazelcast/jet/impl/AbstractJetInstance.java
Show resolved
Hide resolved
hazelcast-jet-core/src/main/java/com/hazelcast/jet/impl/AbstractJetInstance.java
Outdated
Show resolved
Hide resolved
hazelcast-jet-core/src/main/java/com/hazelcast/jet/impl/JobCoordinationService.java
Show resolved
Hide resolved
|
Test FAILed. |
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
viliam-durina
approved these changes
Jan 18, 2019
|
Test PASSed. |
cangencer
reviewed
Jan 21, 2019
| @@ -188,6 +189,14 @@ public Job newJob(@Nonnull DAG dag, @Nonnull JobConfig config) { | |||
| return instance.newJob(dag, config); | |||
| } | |||
|
|
|||
| @Nonnull @Override | |||
| public Job newJobIfAbsent(@Nonnull DAG dag, @Nonnull JobConfig config) { | |||
| if (jarPathname != null) { | |||
There was a problem hiding this comment.
duplicated logic, should be extracted to method
| * | ||
| * <p>See also {@link #newJobIfAbsent}. | ||
| * | ||
| * @throws DuplicateActiveJobNameException if there is an active job with |
There was a problem hiding this comment.
maybe JobAlreadyExistsException would be better?
| * limitations under the License. | ||
| */ | ||
|
|
||
| package com.hazelcast.jet.core; |
There was a problem hiding this comment.
this should not be in core but in .jet as it's a public facing exception
|
Test PASSed. |
cangencer
approved these changes
Jan 23, 2019
There can be at most one active job (i.e., not completed/failed job) with the same name. Once a named job completes, its name can be reused.
metanet
force-pushed
the
0.8/exclusive-job-execution
branch
from
2bf9616
to
3bac224
Compare
|
Test PASSed. |
|
Test PASSed. |
1 similar comment
|
Test PASSed. |
|
Test PASSed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There can be at most one active job (i.e., not completed/failed job)
with the same name. Once a named job completes, its name can be reused.
BREAKING CHANGE: When a new job with a duplicate name is submitted via
newJob(), it throws an exception.