Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Treat empty string properties as null #197

Closed
leszko opened this issue Mar 13, 2020 · 7 comments
Closed

Treat empty string properties as null #197

leszko opened this issue Mar 13, 2020 · 7 comments
Assignees
@azatkhakimov
Labels
good first issue
Milestone
2.0.2

Comments

@leszko
Copy link

leszko commented Mar 13, 2020

When empty string is passed as a property, it should be treated as null, not as a correct value.

The change should be implemented in KubernetesConfig.

Related to hazelcast/charts#58
@leszko leszko mentioned this issue Mar 13, 2020
Closed
@azatkhakimov
Copy link
Contributor

Hi. Can I work on this issue?

@leszko
Copy link
Author

leszko commented Apr 5, 2020

@jawitcher Sure, it's yours!

@azatkhakimov
Copy link
Contributor

@leszko, could you check my PR #201?

@leszko
Copy link
Author

leszko commented Apr 10, 2020

@jawitcher , you've sent it as DRAFT, is it ready to review?

@azatkhakimov
Copy link
Contributor

@leszko , yes, it is. I don't know if I understand the issue correctly, That's why I've send the pr as draft

@leszko
Copy link
Author

leszko commented Apr 14, 2020

@jawitcher Thanks! Added my comments in the related PR.

@leszko
Copy link
Author

leszko commented Apr 16, 2020

Fixed by #201

@leszko leszko closed this as completed Apr 16, 2020
@leszko leszko added this to the 2.0.2 milestone Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azatkhakimov azatkhakimov

Labels
good first issue
Projects
None yet
Milestone
2.0.2
Development

No branches or pull requests
2 participants
@leszko @azatkhakimov