empty properties treated as null

[azatkhakimov]

No description provided.

[devOpsHazelcast]

All committers have signed the CLA.

[devOpsHazelcast]

Can one of the admins verify this patch?

[leszko]

@jawitcher Thanks. I had a look at the PR and it looks like what we need.

Could you also do the following and then change it from DRAFT to the PR?

1. Add the same logic for getMode()
2. Add unit tests
3. Format the code

Thanks!

[azatkhakimov]

@jawitcher Thanks. I had a look at the PR and it looks like what we need.

Could you also do the following and then change it from DRAFT to the PR?

1. Add the same logic for `getMode()`

2. Add unit tests

3. Format the code

Thanks!

I revised the code in accordance with your notes

[leszko]

Added one minor comment. Other than that looks good to me.

@mesutcelik could you also look and approve?

[leszko]

Suggested change

	// given
	Map<String, Comparable> properties = createProperties();
	properties.put(SERVICE_NAME.key(), " ");
	properties.put(SERVICE_DNS.key(), "service-dns");
	new KubernetesConfig(properties);
	// given
	Map<String, Comparable> properties = createProperties();
	properties.put(SERVICE_NAME.key(), " ");
	properties.put(SERVICE_DNS.key(), "service-dns");
	// when
	KubernetesConfig config = new KubernetesConfig(properties);
	// then
	assertEquals("service-dns", config.getServiceDns());

Could you change this test to this format? And could you also change the other tests the same way?

[mesutcelik]

👍 I think we can update helm chart readme how to use the workaround.. setting servine-name: empty_string to be able to use DNS mode. I will leave it to you @leszko

[mesutcelik]

@jawitcher Can you please sign the CLA before the merge?

[azatkhakimov]

@leszko , I changed it

[azatkhakimov]

@jawitcher Can you please sign the CLA before the merge?

Hi. I signed it :)

[leszko]

Looks great 💯

Thanks a lot for the change @jawitcher !