Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add rbac.yaml and related info message #211

Merged
merged 2 commits into from Jun 16, 2020
Merged

Conversation

leszko
Copy link

@leszko leszko commented Jun 15, 2020

If user forgot to assign RBAC, display the help message with the command to do it.

fix #209

Note that it works only for:

  • default namespace
  • default service account

It's still an improvement, because it can help to set up Hazelcast on Kubernetes quicker for beginners.

@leszko leszko requested a review from mesutcelik June 15, 2020 13:22
Copy link
Contributor

@mesutcelik mesutcelik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 please be aware that any break of rbac.yaml url will cause problems with the next and all subsequent releases of hazelcast-kubernetes plugin.

@leszko leszko merged commit 11a4931 into hazelcast:master Jun 16, 2020
@leszko leszko deleted the rbac.yaml branch June 16, 2020 10:40
@leszko leszko modified the milestones: 2.0.2, 1.5.4 Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve permission configuration experience
2 participants