Create our own KubernetesClient (instead of using fabric8) #80
Conversation
|
Test PASSed. |
There was a problem hiding this comment.
Super neat and test-complete too, this is exactly what we need!
Thanks @leszko LGTM
| connection.setRequestProperty("Authorization", String.format("Bearer %s", apiToken)); | ||
|
|
||
| if (connection.getResponseCode() != HTTP_OK) { | ||
| throw new KubernetesClientException(String.format("Failure executing: GET at: %s. Message: %s,", urlString, |
There was a problem hiding this comment.
I suppose we reasonably expect exactly 200 for our GETs (not other 2xx codes or even 3xx redirects etc.)
There was a problem hiding this comment.
Yeah, according to the Kubernetes API Spec [1], 200 is the only valid response.
[1] https://kubernetes.io/docs/reference/generated/kubernetes-api/v1.11/#read-142
| return "Forbidden!Configured service account doesn't have access. Service account may have been revoked. " | ||
| + "endpoints is forbidden: User \"system:serviceaccount:default:default\" cannot list endpoints " | ||
| + "in the namespace \"default\""; | ||
| } |
There was a problem hiding this comment.
hehe, yeah, that's why I added a test specifically for this case ;)
| Endpoints endpoints = createNotReadyEndpoints(2); | ||
| given(client.endpointsByName(NAMESPACE, SERVICE_NAME)).willReturn(endpoints); | ||
|
|
||
| ServiceEndpointResolver sut = new ServiceEndpointResolver(LOGGER, SERVICE_NAME, 0, null, null, NAMESPACE, null, |
There was a problem hiding this comment.
This would seriously benefit from a builder pattern (in general, I don't mean in this PR btw!)
There was a problem hiding this comment.
I can't agree more. But definitely not part of this PR, it's already big.
Create our own Hazelcast KubernetesClient to use Kubernetes REST API. The motivation for this work was to get rid of the dependency to
fabric8.io:kubernetes-client, which is ~11MB. We actually make only one call to Kubernetes API, so there is no good reason to import the whole library.Tested on: Minikube, Pivotal PKS, Google Cloud Platform, and OpenShift Online.
Benefits from this change:
hazelcast-kubernetes: 11MB -> 334KBhazelcast-kubernetesinhazelcast-allServiceEndpointResolverThere are also some drawbacks of this change (but I believe they are minor comparing to the benefits):
KubernetesClient(minor, since it's just one class)hazelcast-kubernetesonly from inside KubernetesRelated to: #75