Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRACKING ISSUE] Check for the minimum size of the bytes read only once per frame [API-1546] #1301

Closed
hz-devops-test opened this issue May 31, 2022 · 2 comments

Comments

@hz-devops-test
Copy link

The tracking issue for the Java side PR.

See hazelcast/hazelcast#21502 for details.


Before this fix, while reading a message frame, we were mistakenly
checking that the bytes we haven't read yet are less than 6 bytes
each time the ClientMessageReader#readFrame is called.

This is problematic for frames that are read in multiple calls,
as the size of the last piece of the frame we are reading might be
actually less than 6 bytes and that is definitely valid. However,
in that case, we were not able to read the remaining part and
continue.

This PR aims to fix this problem by having that check only at the
beginning for each frame, only once per frame. Once we read the frame
length and flags, we will be able to read any number of bytes no
matter how small it is.

@yuce yuce added the to-jira label Sep 2, 2022
@github-actions
Copy link

github-actions bot commented Sep 2, 2022

Internal Jira issue: API-1546

@github-actions github-actions bot changed the title [TRACKING ISSUE] Check for the minimum size of the bytes read only once per frame [TRACKING ISSUE] Check for the minimum size of the bytes read only once per frame [API-1546] Sep 2, 2022
@srknzl srknzl added this to the Backlog milestone Sep 29, 2022
@srknzl
Copy link
Member

srknzl commented Feb 20, 2023

fixed by #1411

@srknzl srknzl closed this as completed Feb 20, 2023
@degerhz degerhz modified the milestones: Backlog, 5.3.0 Feb 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants