Check for the minimum size of the bytes read only once per frame [API-1546] #1411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am aware of the code quality problems. |
Codecov Report
@@ Coverage Diff @@
## master #1411 +/- ##
==========================================
- Coverage 93.37% 93.34% -0.04%
==========================================
Files 466 466
Lines 16623 16623
Branches 1351 1351
==========================================
- Hits 15522 15516 -6
- Misses 799 806 +7
+ Partials 302 301 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
yuce
changed the title
|
@fatihozer0 Sure. You can add to the |
srknzl
requested changes
Nov 7, 2022
|
@fatihozer0 Please add milestone, label etc. to the PR |
…TestRenewed.js and delete ClientMessageReaderTestRenewed.js.
…TestRenewed.js and delete ClientMessageReaderTestRenewed.js.
srknzl
requested changes
Nov 16, 2022
|
All review comments are applied. |
|
@fatihozer0 All comments are not applied see my responses in unresolved comments |
srknzl
previously approved these changes
Nov 28, 2022
srknzl
previously approved these changes
Dec 13, 2022
srknzl
approved these changes
Dec 19, 2022
srknzl
pushed a commit
to fatihozer0/hazelcast-nodejs-client
that referenced
this pull request
Mar 24, 2023
…-1546] (hazelcast#1411) * add test cases to see if there is a problem or not * add all the test cases of Java * add test cases to ClientMessageReaderTest.js from ClientMessageReaderTestRenewed.js and delete ClientMessageReaderTestRenewed.js. * add test cases to ClientMessageReaderTest.js from ClientMessageReaderTestRenewed.js and delete ClientMessageReaderTestRenewed.js. * add test comments * separate the test describers * fix some typos * fix some typos * fix a minor problem * fix the ubuntu-test problem * fix some lint problems
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to add test cases which are added to Java (hazelcast/hazelcast#21502 (comment)) to see if there is a problem and be sure for every commit. But there is a problem which does not allow me to use already implemented methods such as
getLengthorgetTotalLength. Can you check please?I am aware of the name of the file. I am planning to add these test cases to file named ClientMessageReaderTest.js after the end of implementation.