Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Object.setPrototypeOf calls in HazelcastErrors #1005

Merged
merged 2 commits into from Aug 10, 2021
Merged

Delete Object.setPrototypeOf calls in HazelcastErrors #1005

merged 2 commits into from Aug 10, 2021

Conversation

srknzl
Copy link
Member

@srknzl srknzl commented Aug 3, 2021

closes #840

@srknzl srknzl added this to the 5.0 milestone Aug 3, 2021
@srknzl srknzl requested a review from mdumandag August 3, 2021 07:14
mdumandag
mdumandag approved these changes Aug 10, 2021
View reviewed changes
Copy link
Contributor

@mdumandag mdumandag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also remove

/** @internal */
export interface HazelcastErrorConstructor {
    readonly prototype: Error;

    new(message: string, cause?: Error): HazelcastError;
}
``` as it is unused

@srknzl
Copy link
Member Author

srknzl commented Aug 10, 2021

verify

1 similar comment
@srknzl
Copy link
Member Author

srknzl commented Aug 10, 2021

verify

@srknzl srknzl merged commit f86c19a into hazelcast:master Aug 10, 2021
harunalpak pushed a commit to harunalpak/hazelcast-nodejs-client that referenced this pull request Dec 8, 2022
@srknzl
Delete Object.setPrototypeOf calls in HazelcastErrors (hazelcast#1005)
ea313be
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdumandag mdumandag mdumandag approved these changes

Assignees
No one assigned
Labels
Estimation: S Type: Cleanup
Projects
None yet
Milestone
5.0
Development

Successfully merging this pull request may close these issues.

Delete Object.setPrototypeOf calls in HazelcastErrors
2 participants
@srknzl @mdumandag