Fix tests and code samples checker #1020
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srknzl
commented
Aug 16, 2021
| @@ -20,6 +20,7 @@ const DEV_CLUSTER_CONFIG = ` | |||
| xsi:schemaLocation="http://www.hazelcast.com/schema/config | |||
| http://www.hazelcast.com/schema/config/hazelcast-config-4.0.xsd"> | |||
| <cluster-name>dev</cluster-name> | |||
| <jet enabled="true"></jet> | |||
There was a problem hiding this comment.
some code samples use sql, so we need to enable it in the cluster that code samples are run against
srknzl
commented
Aug 16, 2021
| @@ -59,6 +61,7 @@ describe('Data type test', function () { | |||
| let mapName; | |||
| const clientVersionNewerThanFive = TestUtil.isClientVersionAtLeast('5.0'); | |||
| const serverVersionNewerThanFive = TestUtil.isServerVersionAtLeast(client, '5.0'); | |||
| const JET_ENABLED_CONFIG = fs.readFileSync(path.join(__dirname, 'jet_enabled.xml'), 'utf8'); | |||
There was a problem hiding this comment.
all the tests that require sql need jet as enabled
srknzl
commented
Aug 16, 2021
Comment on lines
+349
to
+350
| resultSpy.callCount.should.be.greaterThanOrEqual(4); | ||
| serviceSpy.callCount.should.be.greaterThanOrEqual(4); |
There was a problem hiding this comment.
after a change fetch may not get rows as full in non-last pages. see the issue for details: hazelcast/hazelcast#19313
srknzl
commented
Aug 16, 2021
Comment on lines
+381
to
+382
| resultSpy.callCount.should.be.greaterThanOrEqual(4); | ||
| serviceSpy.callCount.should.be.greaterThanOrEqual(4); |
mdumandag
approved these changes
Aug 16, 2021
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes test failures due to jet being disabled.