Make sql execute return promise api-877 #1046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srknzl
commented
Sep 14, 2021
| @@ -2,3 +2,4 @@ src/codec/*.ts | |||
| src/codec/custom/*.ts | |||
| src/.eslintrc.js | |||
| lib/** | |||
| docs/** | |||
There was a problem hiding this comment.
Needed because of linting does eslint .. I forgot to add docs folder before
srknzl
changed the title
srknzl
commented
Sep 14, 2021
| @@ -483,22 +482,22 @@ describe('Data type test', function () { | |||
| ` | |||
| var map = instance_0.getMap("${mapName}"); | |||
| for (var key = 1; key < 12; key++) { | |||
| map.set(new java.lang.Integer(key), java.time.LocalDate.of(key+50002,key+1,key)); | |||
| map.set(new java.lang.Integer(key), java.time.LocalDate.of(key+5002,key+1,key)); | |||
There was a problem hiding this comment.
I changed this for back compat tests because year was a short in 4.2.
Codecov Report
@@ Coverage Diff @@
## master #1046 +/- ##
==========================================
- Coverage 92.56% 92.32% -0.25%
==========================================
Files 432 432
Lines 16730 16712 -18
Branches 1037 1034 -3
==========================================
- Hits 15486 15429 -57
- Misses 979 1017 +38
- Partials 265 266 +1
Continue to review full report at Codecov.
|
mdumandag
reviewed
Sep 15, 2021
mdumandag
reviewed
Sep 23, 2021
mdumandag
reviewed
Sep 24, 2021
mdumandag
approved these changes
Sep 24, 2021
harunalpak
pushed a commit
to harunalpak/hazelcast-nodejs-client
that referenced
this pull request
Dec 8, 2022
* Make execute return promise * Update code samples and docs * Change date string format * Change year * Update SqlResult * Update sql service * Update tests * Review comments * Fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
executeandexecuteStatementmethods inSqlServicereturn promises ofSqlResult. Update tests, code samples and documentation accordingly.Note that we do not need any conditional tests for back compatibility because using
awaitwith a non async function works. It will convert the returned value to a promise likePromise.resolve(returnedValue)implicitly but I think it is better not to change tests for readability. The promise overhead only affects ~50 tests and the overhead is very small.